expression: check if period is valid in period_add#10380
Merged
qw4990 merged 6 commits intopingcap:masterfrom May 9, 2019
Merged
expression: check if period is valid in period_add#10380qw4990 merged 6 commits intopingcap:masterfrom
period_add#10380qw4990 merged 6 commits intopingcap:masterfrom
Conversation
qw4990
added
component/expression
type/bugfix
Contributor
zz-jason
reviewed
May 7, 2019
XuHuaiyu
reviewed
May 8, 2019
Codecov Report
@@ Coverage Diff @@
## master #10380 +/- ##
================================================
+ Coverage 77.3505% 77.3514% +0.0008%
================================================
Files 412 412
Lines 85724 85692 -32
================================================
- Hits 66308 66284 -24
+ Misses 14387 14379 -8
Partials 5029 5029 |
qw4990
changed the title
period_add is not compatible with MySQLperiod_add
Contributor
Author
|
PTAL |
XuHuaiyu
previously approved these changes
May 9, 2019
Contributor
Author
|
/run-all-tests |
Contributor
Author
|
/run-all-tests |
qw4990
added
status/all tests passed
and removed
status/LGT1
Contributor
Author
|
To solve the CI problem, I |
alivxxx
approved these changes
May 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fix #9736.
What is changed and how it works?
add
validPeriod.Check List
Tests