expression: fix issue that period_diff is not compatible with MySQL 8.0#10383
Merged
zz-jason merged 6 commits intopingcap:masterfrom May 14, 2019
sourcelliu:myfeature-perioddiff
Merged
expression: fix issue that period_diff is not compatible with MySQL 8.0#10383zz-jason merged 6 commits intopingcap:masterfrom sourcelliu:myfeature-perioddiff
period_diff is not compatible with MySQL 8.0#10383zz-jason merged 6 commits intopingcap:masterfrom
sourcelliu:myfeature-perioddiff
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10383 +/- ##
================================================
+ Coverage 77.2926% 77.3211% +0.0285%
================================================
Files 412 412
Lines 86571 86627 +56
================================================
+ Hits 66913 66981 +68
+ Misses 14514 14501 -13
- Partials 5144 5145 +1 |
Contributor
qw4990
added
component/expression
type/bugfix
30 tasks
Contributor
|
@mantuliu #10380 has been merged into |
Contributor
|
PTAL~ @mantuliu |
Contributor
Author
|
@qw4990 take a look.thanks. |
Contributor
|
/run-all-tests |
Contributor
|
/run-all-tests |
Contributor
|
/run-integration-ddl-test |
Contributor
|
/run-all-tests |
Contributor
|
@mantuliu It seems there are some CI problems not caused by your PR. |
Member
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #10383 +/- ##
================================================
+ Coverage 77.2926% 77.3029% +0.0102%
================================================
Files 412 412
Lines 86571 86575 +4
================================================
+ Hits 66913 66925 +12
+ Misses 14514 14505 -9
- Partials 5144 5145 +1 |
Contributor
|
@mantuliu Thanks for your contribution. |
Contributor
Author
|
@qw4990 ok，I will cherry-pick this PR to branch release-2.1. |
Contributor
Author
Contributor
zz-jason
pushed a commit
that referenced
this pull request
May 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fix #10382
What is changed and how it works?
add validPeriod. the method come from #10380 .
@qw4990 I used your 'validPeriod' method ,but change a little.
Check List
Tests