Skip to content

[3.0] ddl: error or skip unsupported partition-related DDLs (#10672)#11373

Merged
sre-bot merged 6 commits intopingcap:release-3.0from
kennytm:cherry-picks-partition-by-to-3.0
Aug 5, 2019
Merged

[3.0] ddl: error or skip unsupported partition-related DDLs (#10672)#11373
sre-bot merged 6 commits intopingcap:release-3.0from
kennytm:cherry-picks-partition-by-to-3.0

Conversation

@kennytm
Copy link
Copy Markdown
Contributor

@kennytm kennytm commented Jul 22, 2019

What problem does this PR solve?

Cherry-picks #10672 to release-3.0.

Additionally, included the test case shown in #10672 (comment)

What is changed and how it works?

Check List

Tests

  • Unit test

Code changes

  • Has persistent data change

Side effects

Related changes

  • Need to update the documentation (?)

kennytm added 2 commits July 23, 2019 02:35
* ddl: error or skip unsupported partition-related DDLs

* go.mod: stop replacing parser since the PR is merged

* ddl: addressed comment
@kennytm kennytm force-pushed the cherry-picks-partition-by-to-3.0 branch from 90e472f to 018924b Compare July 22, 2019 18:35
@tiancaiamao
Copy link
Copy Markdown
Contributor

LGTM @crazycs520

@zz-jason zz-jason requested review from crazycs520 and winkyao and removed request for crazycs520 August 5, 2019 08:59
@zz-jason
Copy link
Copy Markdown
Member

zz-jason commented Aug 5, 2019

@kennytm seems CI is failed, could you merge master and fix ci firstly? after that we can process on this PR.

Copy link
Copy Markdown
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. status/can-merge Indicates a PR has been approved by a committer. and removed status/ReqChange labels Aug 5, 2019
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Aug 5, 2019

/run-all-tests

@sre-bot sre-bot merged commit 25c8215 into pingcap:release-3.0 Aug 5, 2019
@kennytm kennytm deleted the cherry-picks-partition-by-to-3.0 branch August 5, 2019 19:02
@you06 you06 added the sig/sql-infra SIG: SQL Infra label Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants