expression: make sysdate unfoldable#7838
Merged
zz-jason merged 2 commits intopingcap:masterfrom Oct 8, 2018
Merged
Conversation
Member
Author
zz-jason
changed the title
eurekaka
reviewed
Oct 8, 2018
alivxxx
reviewed
Oct 8, 2018
|
|
||
| func (s *testEvaluatorSuite) TestUnfoldableFuncs(c *C) { | ||
| defer testleak.AfterTest(c)() | ||
| _, ok := unFoldableFunctions[ast.Sysdate] |
Contributor
There was a problem hiding this comment.
When the issue was fixed in the first time, we also added a unit test but it did not prevent from change. Maybe it is better to add explain test or add some comments so that we know why it is unfoldable.
Member
Author
There was a problem hiding this comment.
A explain test is added, PTAL.
Contributor
|
/run-all-tests |
This was referenced Oct 15, 2018
zz-jason
added a commit
that referenced
this pull request
Oct 15, 2018
zz-jason
added a commit
that referenced
this pull request
Oct 15, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fix #4245
What is changed and how it works?
add
sysdateto the unfoldable function list.Check List
Tests
Related changes