-
Notifications
You must be signed in to change notification settings - Fork 6.2k
expression: make sysdate unfoldable #7838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| // Copyright 2018 PingCAP, Inc. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package expression | ||
|
|
||
| import ( | ||
| . "github.com/pingcap/check" | ||
| "github.com/pingcap/tidb/ast" | ||
| "github.com/pingcap/tidb/util/testleak" | ||
| ) | ||
|
|
||
| func (s *testEvaluatorSuite) TestUnfoldableFuncs(c *C) { | ||
| defer testleak.AfterTest(c)() | ||
| _, ok := unFoldableFunctions[ast.Sysdate] | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. When the issue was fixed in the first time, we also added a unit test but it did not prevent from change. Maybe it is better to add explain test or add some comments so that we know why it is unfoldable.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. A explain test is added, PTAL. |
||
| c.Assert(ok, IsTrue) | ||
| } | ||
Uh oh!
There was an error while loading. Please reload this page.