refactor(core): re-implement useAtom with useReducer#687
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/pmndrs/jotai/9Zch3BP9tA21Q54SQWYs4oCEXuEL |
|
This improves https://github.com/dai-shi/will-this-react-global-state-work-in-concurrent-rendering results: v1.3.2 |
|
I would like to test if react devtools work before merging. (codesandbox ci is not working. 😓 ) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2e96c2c:
|
Co-authored-by: Mathis Møller <mmm@cryosinternational.com>
Co-authored-by: Mathis Møller <mmm@cryosinternational.com>
Co-authored-by: Mathis Møller <mmm@cryosinternational.com>
Thisen
left a comment
There was a problem hiding this comment.
Looks good to me. Surprised that it didn't require test changes.
uMS won't land, #686 doesn't work so far.
I feel like simpler solution with useReducer would work better.
This simplifies a lot. Also, fixes weird issues in devtools.