Skip to content

refactor(core,quey): batch flush pending and useState based useAtom#700

Closed
dai-shi wants to merge 8 commits intomainfrom
batch-flush-pending-and-use-state
Closed

refactor(core,quey): batch flush pending and useState based useAtom#700
dai-shi wants to merge 8 commits intomainfrom
batch-flush-pending-and-use-state

Conversation

@dai-shi
Copy link
Copy Markdown
Member

@dai-shi dai-shi commented Sep 10, 2021

While working on #687, I thought there should be an easier impl with useState.
This seems to be working. A few tests have to be tweaked.
Still, it reads a mutable store in render. 🤔

@vercel
Copy link
Copy Markdown

vercel Bot commented Sep 10, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pmndrs/jotai/ASkRy1Uq4GkjVNVu6cYQPZS1Dawb
✅ Preview: https://jotai-git-batch-flush-pending-and-use-state-pmndrs.vercel.app

@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci Bot commented Sep 10, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 659afeb:

Sandbox Source
React Configuration
React Typescript Configuration
React Browserify Configuration
React Snowpack Configuration
Next.js Configuration

@dai-shi
Copy link
Copy Markdown
Member Author

dai-shi commented Sep 11, 2021

Okay, I don't think this is worth it. We would still need to migrate to uSES eventually.
I will file a smaller PR to just fix some issues found in this PR.

@dai-shi dai-shi closed this Sep 11, 2021
@dai-shi dai-shi reopened this Sep 11, 2021
@dai-shi dai-shi closed this Sep 11, 2021
@dai-shi dai-shi deleted the batch-flush-pending-and-use-state branch September 11, 2021 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant