Skip to content

Add JDK25 signatures#272

Merged
uschindler merged 2 commits intopoliceman-tools:mainfrom
kaivalnp:jdk25
Sep 28, 2025
Merged

Add JDK25 signatures#272
uschindler merged 2 commits intopoliceman-tools:mainfrom
kaivalnp:jdk25

Conversation

@kaivalnp
Copy link
Copy Markdown
Contributor

Description

For jdk-deprecated-25 I ran:

ant generate-deprecated

For jdk-internal-25 I ran:

ant generate-internal

but it gave:

generate-internal:
     [java] Exception in thread "main" java.lang.IllegalArgumentException: InternalApiGen only works till Java 23, for later versions use the generated file from Java 23.
     [java]     at de.thetaphi.forbiddenapis.InternalApiGen.<init>(InternalApiGen.java:59)
     [java]     at de.thetaphi.forbiddenapis.InternalApiGen.<init>(InternalApiGen.java:39)
     [java]     at de.thetaphi.forbiddenapis.InternalApiGen.main(InternalApiGen.java:102)
     [java] Java Result: 1

..so I copied jdk-internal-24

For jdk-unsafe-25 I included the bundled jdk-unsafe-24

@uschindler
Copy link
Copy Markdown
Member

Hi, thanks for the PR. I will check what was done previously so we forget nothing.

The release has to wait a bit, because traditionally forbiddenapis will update to corresponding ASM release. It also needs to be updated to get preliminary support also for Java 26. In addition, I need to update Maven Central Sonatype deployments as this changed begin of August.

So give me a few days, unfortunately I am very busy preparing a long trip to Australia.

@uschindler
Copy link
Copy Markdown
Member

Wah stupid Gradle 9 no longer allows Java 8. Need to adapt GitHub actions. 🤮

Sorry takes longer this time. 🍺

@kaivalnp
Copy link
Copy Markdown
Contributor Author

Sounds good, thanks! Just wanted to get the ball rolling :)

@uschindler uschindler merged commit 53aa89f into policeman-tools:main Sep 28, 2025
1 check passed
@uschindler
Copy link
Copy Markdown
Member

Thanks, I merged this after the github runner was happy.

I will take care of updating ASM soon. I hope a release happens during this week. If not, we may need to realease forbiddenapis before my long trip with outdated ASM (which works for Java 25, but will not work for Java 26 - which is no longer an issue only for regenerating signatures like you did here).

@kaivalnp kaivalnp deleted the jdk25 branch September 28, 2025 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants