Add 2025_Saag_NorthPontic#299
Conversation
|
Thanks @Tlkhi for submitting this! janno file:
I don't have any comments to other files as they look all good. |
Thank you for your comments,
|
|
Thanks for this package submission, @Tlkhi, and thanks for the prompt review, @martynamolak! To quickly address some points:
Sooner or later we'll have to introduce a list of the special conventions for the community-archive 🤔
|
thank you for your comments, |
|
Table 1 of the paper features the short versions of the group labels prominently. I think it is important that the direct link to this published analysis is maintained in the package. But I understand if you're exhausted by this request, @Tlkhi. I can offer to do the adjustment myself in the next couple of weeks, or find somebody who's willing to do it. |
|
I fixed the wrong coordinates and added the analysis labels used in the publication as secondary group names. Will merge now. |
PR Checklist for a new package submission
POSEIDON.ymlconforms to the general title structure suggested here:<Year>_<Last name of first author>_<Region, time period or special feature of the paper>, e.g.2021_Zegarac_SoutheasternEurope,2021_SeguinOrlando_BellBeakeror2021_Kivisild_MedievalEstonia.Poseidon_IDof the form<Original Poseidon_ID>_<Initials of the main author>_<Year>. Re-analysed versions ofI1685(Lazaridis et al. 2016) should, for example, be assigned the IDsI1685_IL22(Lazaridis et al. 2022) andI1685_IL25(Lazaridis et al. 2025).POSEIDON.ymlfile with not just the file-referencing fields, but also the following meta-information fields present and filled:poseidonVersion,title,description,contributor,packageVersion,lastModified(see here for their definition).jannofile (for a list of available fields look here and here for more detailed documentation about them)..bibfile with the necessary literature references for each sample in the.jannofile.POSEIDON.ymlfile and there are no additional, supplementary files in the submission that are not documented there..jannoand.bibfile are all named after the package title and only differ in the file extension.POSEIDON.ymlfile is1.0.0.poseidonVersionof the package in thePOSEIDON.ymlfile is set to the latest version of the Poseidon schema.POSEIDON.ymlfile contains the corresponding checksums for the fieldsgenoFile,snpFile,indFile,jannoFileandbibFile.CHANGELOGfile or one with a single entry for version1.0.0.Publicationcolumn in the.jannofile is filled and the respective.bibfile has complete entries for the listed mentioned keys..jannofile does not include any empty columns or columns only filled withn/a..jannofile adheres to the standard order as defined in the Poseidon schema here..jannoand the.ssffiles are not fully quoted, so they only use single- or double quotes ("...",'...') to enclose text fields where it is strictly necessary (i.e. their entry includes a TAB).trident validate --fullGeno.git lfs migrate import --no-rewrite path/to/file.bed(see here).