Add 2024_Antonio_HighMobility#302
Conversation
|
Nice! I'll try to find a reviewer asap 👍 |
|
Thankfully, @denisazlamalova has agreed to review this package submission! Please see the review guide here: https://www.poseidon-adna.org/#/archive_reviewer_guide By now there are also a lot of other PRs that may serve as a reference, e.g. #299 or #275. |
|
Thank you @Tlkhi for you submission! I have gone through the files and only have some minor comments regarding the .janno file.
Other than that, the rest of the files and their content look good to me. |
|
Thanks for the review, @denisazlamalova. Maybe you could address 1. and 3., @Tlkhi. 2. is not so important - we'll adjust how this is done in Poseidon v3.0.0 anyway. I'll have a final look when you're done 👍 |
|
I'm sorry that it took me so long to get back to this. I implemented the suggested changes myself now and will merge the package. |
PR Checklist for a new package submission
POSEIDON.ymlconforms to the general title structure suggested here:<Year>_<Last name of first author>_<Region, time period or special feature of the paper>, e.g.2021_Zegarac_SoutheasternEurope,2021_SeguinOrlando_BellBeakeror2021_Kivisild_MedievalEstonia.Poseidon_IDof the form<Original Poseidon_ID>_<Initials of the main author>_<Year>. Re-analysed versions ofI1685(Lazaridis et al. 2016) should, for example, be assigned the IDsI1685_IL22(Lazaridis et al. 2022) andI1685_IL25(Lazaridis et al. 2025).POSEIDON.ymlfile with not just the file-referencing fields, but also the following meta-information fields present and filled:poseidonVersion,title,description,contributor,packageVersion,lastModified(see here for their definition).jannofile (for a list of available fields look here and here for more detailed documentation about them)..bibfile with the necessary literature references for each sample in the.jannofile.POSEIDON.ymlfile and there are no additional, supplementary files in the submission that are not documented there..jannoand.bibfile are all named after the package title and only differ in the file extension.POSEIDON.ymlfile is1.0.0.poseidonVersionof the package in thePOSEIDON.ymlfile is set to the latest version of the Poseidon schema.POSEIDON.ymlfile contains the corresponding checksums for the fieldsgenoFile,snpFile,indFile,jannoFileandbibFile.CHANGELOGfile or one with a single entry for version1.0.0.Publicationcolumn in the.jannofile is filled and the respective.bibfile has complete entries for the listed mentioned keys..jannofile does not include any empty columns or columns only filled withn/a..jannofile adheres to the standard order as defined in the Poseidon schema here..jannoand the.ssffiles are not fully quoted, so they only use single- or double quotes ("...",'...') to enclose text fields where it is strictly necessary (i.e. their entry includes a TAB).trident validate --fullGeno.git lfs migrate import --no-rewrite path/to/file.bed(see here).