fix: do not let setProperty change the prototype#1899
Merged
alexander-fenster merged 2 commits intomasterfrom Jun 23, 2023
Merged
fix: do not let setProperty change the prototype#1899alexander-fenster merged 2 commits intomasterfrom
alexander-fenster merged 2 commits intomasterfrom
Conversation
bcoe
reviewed
Jun 23, 2023
bcoe
approved these changes
Jun 23, 2023
bcoe
left a comment
bcoe
left a comment
There was a problem hiding this comment.
LGTM, but ideally we'd add a test here:
https://github.com/protobufjs/protobuf.js/blob/master/tests/api_util.js
Merged
ghost
mentioned this pull request
jportner
pushed a commit
to jportner/protobuf.js
that referenced
this pull request
Jul 10, 2023
* fix: do not let setProperty change the prototype * test: add unit test
alexander-fenster
added a commit
that referenced
this pull request
Aug 11, 2023
* fix: do not let setProperty change the prototype * test: add unit test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #1731, fixes a bug introduced in #1256.