fix: Make optional Node module lookups bundler-safe#2237
Merged
Conversation
alexander-fenster
approved these changes
May 9, 2026
Merged
This was referenced May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the internal optional module lookups that can confuse bundlers after
util.inquirewas inlined.fsis now resolved through a literal optional require, with abrowserfield mapping so browser bundles receive an empty stub that is normalized tonull.Bufferis read from the runtime environment instead of going throughutil.inquire, andLongis resolved through a literal optionalrequire("long")so bundlers can include it normally.Also marks
util.inquireas deprecated so we can remove it in a future release.Supersedes #2226.
Follow-up to #2146.