fix: Backport bundler-safe optional module lookups#2254
Merged
Conversation
alexander-fenster
approved these changes
May 17, 2026
This was referenced May 17, 2026
freben
added a commit
to backstage/backstage
that referenced
this pull request
May 26, 2026
Since protobufjs 7.5.9, the @protobufjs/inquire utility is no longer called with dynamic module names (replaced by bundler-safe lookups in protobufjs/protobuf.js#2254). However, webpack/rspack still statically analyzes the inquire source and emits a "Critical dependency" warning for its require(moduleName) pattern. This is a false positive — the code path is dead in practice. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #2237 to the 7.x line as suggested in #2214.
Also updates the fetch micromodule that depends on inquire to obtain fs. It is currently published at
1.1.0, but the 7.x branch had an unreleased version bump to1.1.1, so this PR reverts that bookkeeping and lets release automation pick up the changes as the actual1.1.1release.Note that fetch needs to be published first, and the release-please PR for the main package amended, bumping the fetch dependency version.