fix(TableStateful): Prevent in-place sorting in TableStateful to restore initial sort on NOS#7715
Merged
deleonio merged 2 commits intopublic-ui:developfrom May 15, 2025
Merged
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
deleonio
approved these changes
May 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When using TableStateful, sorting a column modifies the original data array (
_data) in place. As a result:Root Cause
In-place mutation of the
_dataarray using.sort()mutates the original state reference, losing the pristine initial sort order.Changes
let sortedData = this.state._datawith a spread copyconst sortedData = [...this.state._data]sorton the copy instead of the original stateThis PR fixes #7634