Skip to content

fix(TableStateful): Prevent in-place sorting in TableStateful to restore initial sort on NOS #7715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deleonio merged 2 commits into from
May 15, 2025
Merged

fix(TableStateful): Prevent in-place sorting in TableStateful to restore initial sort on NOS #7715

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
771a520
fix(table-stateful): copy _data to avoid in-place sorting
larrrssss May 15, 2025
54d444e
Merge branch 'develop' into 7634-reset-table-sorting
deleonio May 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/components/src/components/table-stateful/shadow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,9 +410,9 @@ export class KolTableStateful implements TableAPI {
return;
}

let sortedData: KoliBriTableDataType[] = this.state._data;
const sortedData: KoliBriTableDataType[] = [...this.state._data];
if (this.sortData.length > 0) {
sortedData = this.state._data.sort((a: KoliBriTableDataType, b: KoliBriTableDataType) => {
sortedData.sort((a: KoliBriTableDataType, b: KoliBriTableDataType) => {
for (let index = 0; index < this.sortData.length; index++) {
const data = this.sortData[index];
const result = data.compareFn(a, b);
Expand Down
Loading
⚡