Conversation
dkliban
force-pushed
the
4027
branch
2 times, most recently
from
2bce299 to
9b28308
Compare
dralley
reviewed
Jul 1, 2025
dkliban
force-pushed
the
4027
branch
3 times, most recently
from
716fdf3 to
ff944ee
Compare
ggainey
requested changes
Jul 1, 2025
Contributor
ggainey
left a comment
ggainey
left a comment
There was a problem hiding this comment.
Can we get the test modified to use a user that has only the required permissions? The test currently runs as "admin", so we're not testing the RBAC work here.
dkliban
force-pushed
the
4027
branch
2 times, most recently
from
a9bbe13 to
ad137ba
Compare
ggainey
approved these changes
Jul 1, 2025
|
|
||
| LOCKED_ROLES = { | ||
| "rpm.rpm_package_uploader": [ | ||
| "rpm.upload_rpm_packages", |
| file_to_upload.write(requests.get(file_to_use).content) | ||
| upload_attrs = {"file": file_to_upload.name, "pulp_labels": labels} | ||
| rpm_package_api.upload(**upload_attrs) | ||
| assert ctx.value.status == 403 |
| # Single unit upload | ||
| file_to_use = os.path.join(RPM_UNSIGNED_FIXTURE_URL, RPM_PACKAGE_FILENAME) | ||
|
|
||
| with gen_user(model_roles=["rpm.rpm_package_uploader"]): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #4027