Add support for multiple values per key#555
Merged
skyamgarp merged 5 commits intopuppetlabs:mainfrom Apr 17, 2026
Merged
Conversation
Contributor
|
@bwitt Please resolve the conflicts. |
Contributor
Author
|
@span786 done! |
Contributor
|
A PR has been created to execute tests for this contribution: #562 |
Contributor
Signed-off-by: Brian Witt <brianwitt@gmail.com>
Contributor
Author
|
@skyamgarp I've added a fix, let me know how that looks! |
skyamgarp
approved these changes
Apr 17, 2026
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a clone of #481 to hopefully get it passing and merged.
This change adds support for ini files in which the same key is used multiple times for lists of values, for example:
To set multiple values, an array of values can be passed to the value property of ini_setting.
When passing a single value, the module works as before, with one exception: when a single value is passed to value, but the ini file already contains multiple lines with the same key, any additional lines will now be removed instead of retained.
Thanks to @omolenkamp for the original PR.
Additional Context
Add any additional context about the problem here.
Related Issues (if any)
Fixes #41
Related to #481
Checklist
puppet apply)