add Stdlib::Syslogfacility type#1005
Merged
sheenaajay merged 1 commit intopuppetlabs:masterfrom Sep 18, 2019
Merged
Conversation
This was referenced Mar 9, 2019
alexjfisher
reviewed
Mar 9, 2019
bastelfreak
added a commit
to bastelfreak/puppet-nrpe
that referenced
this pull request
Mar 9, 2019
The syslogfacility type is present in stdlib, so we should use it. Before merging this, puppetlabs/puppetlabs-stdlib#1005 needs to be released. We also need to update metadata.json
iglov
approved these changes
Mar 9, 2019
alexjfisher
reviewed
Mar 11, 2019
Contributor
|
Hi @bastelfreak ,Hasn't seen any activity in this PR, do you think you'll be able to work on it in the near future? No pressure, just checking in. |
Collaborator
|
@sheenaajay Is there any extra work required? I don't think my nitpick should be a blocker. |
Contributor
|
Thank you @alexjfisher . |
bastelfreak
force-pushed
the
facility
branch
from
a332eaa to
d006c01
Compare
bastelfreak
force-pushed
the
facility
branch
from
d006c01 to
797b6bf
Compare
Collaborator
Author
|
@sheenaajay I rebased it |
Contributor
|
|
Contributor
|
Thank you for submitting the PR @bastelfreak. |
Contributor
|
Great work... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.