(CONT-173) - Updating deprecated facter instances#1277
Merged
Conversation
Prior to this PR, this module contained instances of Facter::Util::Resolution.exec and Facter::Util::Resolution.which, which are deprecated. This PR aims to replace these exec helpers with their supported Facter::Core::Execution counterparts. This PR: Replaces all Facter::Util::Resolution instances with corresponding Facter::Core::Execution exec helpers
jordanbreen28
force-pushed
the
cont-173/main/update_deprecated_facter
branch
from
f44b580 to
8c9413d
Compare
ekohl
reviewed
Oct 14, 2022
Collaborator
ekohl
left a comment
ekohl
left a comment
There was a problem hiding this comment.
Argh, so many unrelated issues. I wonder why this isn't using Etc.getpwuid(0).dir, at least on Linux or even POSIX.
Also, I wonder why this isn't restricted to not run on Windows.
| @@ -39,7 +39,7 @@ def returnt_root_home | |||
| confine kernel: :aix | |||
| root_home = nil | |||
Collaborator
There was a problem hiding this comment.
This line is weird and should really be inside setcode.
Contributor
|
@ekohl Nice spot with those finds. Would you mind creating an issue so we can track them? |
Collaborator
|
I wonder why this was merged since #1278 was pretty trivial to write. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this PR, this module contained instances of Facter::Util::Resolution.exec and Facter::Util::Resolution.which, which are deprecated. This PR aims to replace these exec helpers with their supported Facter::Core::Execution counterparts.
This PR:
Replaces all Facter::Util::Resolution instances with corresponding Facter::Core::Execution exec helpers