Determine root_home without shelling out#1278
Merged
jordanbreen28 merged 1 commit intopuppetlabs:mainfrom Oct 17, 2022
Merged
Conversation
chelnak
reviewed
Oct 17, 2022
| end | ||
| end | ||
|
|
||
| Facter.add(:root_home) do |
Contributor
There was a problem hiding this comment.
Nice removal of code @ekohl.
What do you think about confining the fact to osx and linux? I noticed the test just checks for nil when :kernel is Windows.
Collaborator
Author
There was a problem hiding this comment.
Today there's also fact for AIX and I'd expect this code to work on any unix (like Solaris). However, I can't test that since I don't have access to those systems. Any you could confine it to non-Windows but I think this is effectively the same.
This uses Ruby's Etc library to determine the root home. This avoids shelling out and writing multiple implementations.
ekohl
force-pushed
the
simplify-root-home
branch
from
8a8ebc0 to
657cd71
Compare
bastelfreak
approved these changes
Oct 17, 2022
jordanbreen28
approved these changes
Oct 17, 2022
Contributor
jordanbreen28
left a comment
jordanbreen28
left a comment
There was a problem hiding this comment.
Looks good! Thanks @ekohl.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses Ruby's Etc library to determine the root home. This avoids shelling out and writing multiple implementations.