Assert number of messages in test_messages_documentation.py#6145
Merged
Pierre-Sassoulas merged 6 commits intopylint-dev:mainfrom Apr 2, 2022
Merged
Assert number of messages in test_messages_documentation.py#6145Pierre-Sassoulas merged 6 commits intopylint-dev:mainfrom
Pierre-Sassoulas merged 6 commits intopylint-dev:mainfrom
Conversation
for more information, see https://pre-commit.ci
DanielNoord
requested changes
Apr 2, 2022
DanielNoord
reviewed
Apr 2, 2022
for more information, see https://pre-commit.ci
Co-authored-by: Daniël van Noord <13665637+DanielNoord@users.noreply.github.com>
Pull Request Test Coverage Report for Build 2083163057
💛 - Coveralls |
DanielNoord
approved these changes
Apr 2, 2022
| expected_messages = self._get_expected() | ||
| actual_messages = self._get_actual() | ||
| if self.is_good_test_file(): | ||
| assert actual_messages.total() == 0 # type: ignore[attr-defined] |
Collaborator
There was a problem hiding this comment.
I think it is because MessageCounter is still Counter without the totals. But this is fine for me!
Pierre-Sassoulas
added
the
Maintenance
Member
|
Thank you @matusvalo ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description