Skip to content

make simple root page update optional#1145

Merged
cooperlees merged 7 commits intopypa:mainfrom
LeoQuote:support_skip_root
Jul 13, 2022
Merged

make simple root page update optional#1145
cooperlees merged 7 commits intopypa:mainfrom
LeoQuote:support_skip_root

Conversation

@LeoQuote
Copy link
Copy Markdown
Contributor

Genrating simple root page is sometimes time-consuming , and it is not really used by pip( pip will use https://pypi.org/simple/my-package/ directly ), thus not so important, this option could lead to an unsynced simple root page , but no critical damage is made.

@LeoQuote LeoQuote marked this pull request as ready for review July 11, 2022 03:16
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 11, 2022

Codecov Report

Merging #1145 (73398f0) into main (25a7c2d) will increase coverage by 0.01%.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##             main    #1145      +/-   ##
==========================================
+ Coverage   79.48%   79.50%   +0.01%     
==========================================
  Files          16       16              
  Lines        2608     2610       +2     
  Branches      476      477       +1     
==========================================
+ Hits         2073     2075       +2     
  Misses        385      385              
  Partials      150      150              
Impacted Files Coverage Δ
src/bandersnatch/main.py 75.24% <50.00%> (+0.24%) ⬆️
src/bandersnatch/mirror.py 83.66% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25a7c2d...73398f0. Read the comment docs.

@LeoQuote LeoQuote marked this pull request as draft July 11, 2022 03:57
@LeoQuote LeoQuote marked this pull request as ready for review July 11, 2022 04:10
@LeoQuote LeoQuote force-pushed the support_skip_root branch from a2afe75 to 0c564bb Compare July 11, 2022 04:11
Copy link
Copy Markdown
Contributor

@cooperlees cooperlees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff with a great unit test. Lets just make the argument name a little more explicit so its harder to mis understand.

Comment thread src/bandersnatch/main.py Outdated
Comment thread src/bandersnatch/main.py Outdated
Co-authored-by: Cooper Lees <me@cooperlees.com>
@LeoQuote LeoQuote requested a review from cooperlees July 12, 2022 08:12
Copy link
Copy Markdown
Contributor

@cooperlees cooperlees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! This could be useful for peoples.

@cooperlees cooperlees merged commit 2913033 into pypa:main Jul 13, 2022
@LeoQuote LeoQuote deleted the support_skip_root branch July 13, 2022 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants