Skip to content

[stubtest] Add __warningregistry__ to the list of ignored module dunders#14218

Merged
sobolevn merged 2 commits intomasterfrom
sobolevn-patch-4
Nov 29, 2022
Merged

[stubtest] Add __warningregistry__ to the list of ignored module dunders#14218
sobolevn merged 2 commits intomasterfrom
sobolevn-patch-4

Conversation

@sobolevn
Copy link
Copy Markdown
Member

@sobolevn sobolevn commented Nov 29, 2022

@sobolevn sobolevn requested a review from AlexWaygood November 29, 2022 11:57
Comment thread mypy/stubtest.py Outdated
Comment on lines +1250 to +1251
# Created by `warnings.warn`, does not make much sense to have in stubs:
"__warningregistry__",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this entry should go above the TODO comment on line 1246; it's here to stay :)

Copy link
Copy Markdown
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sobolevn sobolevn merged commit 3a3cf41 into master Nov 29, 2022
@sobolevn sobolevn deleted the sobolevn-patch-4 branch November 29, 2022 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants