Skip to content

remove hl.signal/wait#1791

Merged
shunting314 merged 1 commit intomainfrom
shunting314/stack/17
Mar 26, 2026
Merged

remove hl.signal/wait#1791
shunting314 merged 1 commit intomainfrom
shunting314/stack/17

Conversation

@shunting314
Copy link
Copy Markdown
Contributor

@shunting314 shunting314 commented Mar 23, 2026 •
edited
Loading

Stacked PRs:

remove hl.signal/wait

since it's functionality overlaps with hl.triton_kernel. Most of the runtime APIs in triton_helpers.py are removed due to no usage. We can add them back if there is usage in future

shunting314 added a commit that referenced this pull request Mar 23, 2026
@shunting314
remove hl.signal/wait
63ce1c5 
stack-info: PR: #1791, branch: shunting314/stack/17
@shunting314 shunting314 force-pushed the shunting314/stack/17 branch from b482691 to 63ce1c5 Compare March 23, 2026 21:46
This was referenced Mar 23, 2026
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Mar 23, 2026
@shunting314 shunting314 marked this pull request as draft March 23, 2026 22:34
@shunting314 shunting314 changed the base branch from shunting314/stack/16 to main March 23, 2026 22:34
shunting314 added a commit that referenced this pull request Mar 23, 2026
@shunting314
remove hl.signal/wait
f6c766c 
stack-info: PR: #1791, branch: shunting314/stack/17
@shunting314 shunting314 force-pushed the shunting314/stack/17 branch from 63ce1c5 to f6c766c Compare March 23, 2026 22:35
@shunting314 shunting314 changed the base branch from main to shunting314/stack/16 March 23, 2026 22:35
@shunting314 shunting314 marked this pull request as ready for review March 23, 2026 22:35
@shunting314 shunting314 marked this pull request as draft March 23, 2026 22:38
@shunting314 shunting314 changed the base branch from shunting314/stack/16 to main March 23, 2026 22:38
@shunting314 shunting314 force-pushed the shunting314/stack/17 branch from f6c766c to 11f2d9c Compare March 23, 2026 22:38
shunting314 added a commit that referenced this pull request Mar 23, 2026
@shunting314
remove hl.signal/wait
11f2d9c 
stack-info: PR: #1791, branch: shunting314/stack/17
@shunting314 shunting314 changed the base branch from main to shunting314/stack/16 March 23, 2026 22:38
@shunting314 shunting314 marked this pull request as ready for review March 23, 2026 22:39
@shunting314 shunting314 requested review from jansel and yf225 March 23, 2026 22:40
@shunting314 shunting314 marked this pull request as draft March 24, 2026 00:17
@shunting314 shunting314 changed the base branch from shunting314/stack/16 to main March 24, 2026 00:17
@shunting314 shunting314 force-pushed the shunting314/stack/17 branch from 11f2d9c to 7bbe9c6 Compare March 24, 2026 00:17
@shunting314 shunting314 changed the base branch from main to shunting314/stack/16 March 24, 2026 00:18
@shunting314 shunting314 marked this pull request as ready for review March 24, 2026 00:18
@shunting314 shunting314 force-pushed the shunting314/stack/17 branch from bb88ba5 to 30e89b2 Compare March 24, 2026 17:52
@shunting314 shunting314 changed the base branch from main to shunting314/stack/16 March 24, 2026 17:52
@shunting314 shunting314 marked this pull request as ready for review March 24, 2026 17:52
@shunting314 shunting314 marked this pull request as draft March 24, 2026 19:03
@shunting314 shunting314 changed the base branch from shunting314/stack/16 to main March 24, 2026 19:03
@shunting314 shunting314 force-pushed the shunting314/stack/17 branch from 30e89b2 to fcd8bb4 Compare March 24, 2026 19:03
@shunting314 shunting314 changed the base branch from main to shunting314/stack/16 March 24, 2026 19:04
@shunting314 shunting314 marked this pull request as ready for review March 24, 2026 19:04
@shunting314 shunting314 marked this pull request as draft March 25, 2026 17:19
@shunting314 shunting314 changed the base branch from shunting314/stack/16 to main March 25, 2026 17:19
@shunting314 shunting314 force-pushed the shunting314/stack/17 branch from fcd8bb4 to cc6cf9a Compare March 25, 2026 17:20
@shunting314 shunting314 changed the base branch from main to shunting314/stack/16 March 25, 2026 17:20
@shunting314 shunting314 marked this pull request as ready for review March 25, 2026 17:20
@shunting314 shunting314 marked this pull request as draft March 25, 2026 17:24
@shunting314 shunting314 changed the base branch from shunting314/stack/16 to main March 25, 2026 17:24
@shunting314 shunting314 force-pushed the shunting314/stack/17 branch from cc6cf9a to f2aeb7c Compare March 25, 2026 17:25
@shunting314 shunting314 changed the base branch from main to shunting314/stack/16 March 25, 2026 17:25
@shunting314 shunting314 marked this pull request as ready for review March 25, 2026 17:25
@shunting314 shunting314 marked this pull request as draft March 25, 2026 17:35
@shunting314 shunting314 changed the base branch from shunting314/stack/16 to main March 25, 2026 17:35
@shunting314 shunting314 force-pushed the shunting314/stack/17 branch from f2aeb7c to 7411998 Compare March 25, 2026 17:35
@shunting314 shunting314 changed the base branch from main to shunting314/stack/16 March 25, 2026 17:35
@shunting314 shunting314 marked this pull request as ready for review March 25, 2026 17:35
@shunting314
remove hl.signal/wait
66f0ec9 
stack-info: PR: #1791, branch: shunting314/stack/17
@shunting314 shunting314 marked this pull request as draft March 26, 2026 06:30
@shunting314 shunting314 changed the base branch from shunting314/stack/16 to main March 26, 2026 06:30
@shunting314 shunting314 force-pushed the shunting314/stack/17 branch from 7411998 to 66f0ec9 Compare March 26, 2026 06:31
@shunting314 shunting314 marked this pull request as ready for review March 26, 2026 06:31
@shunting314 shunting314 mentioned this pull request Mar 26, 2026
Merged
@shunting314 shunting314 merged commit 62156dd into main Mar 26, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yf225 yf225 yf225 approved these changes

@jansel jansel Awaiting requested review from jansel

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shunting314 @yf225
⚡