Merged
Conversation
shunting314
added a commit
that referenced
this pull request
Mar 24, 2026
stack-info: PR: #1797, branch: shunting314/stack/18
shunting314
force-pushed
the
shunting314/stack/18
branch
from
2afcd24 to
9160dce
Compare
This was referenced Mar 24, 2026
Merged
meta-cla
bot
added
the
CLA Signed
shunting314
force-pushed
the
shunting314/stack/18
branch
from
9160dce to
f0cc4bd
Compare
shunting314
force-pushed
the
shunting314/stack/18
branch
from
da612eb to
bfdb55a
Compare
shunting314
force-pushed
the
shunting314/stack/18
branch
from
bfdb55a to
4d2178a
Compare
yf225
approved these changes
Mar 25, 2026
jansel
reviewed
Mar 26, 2026
| if ( | ||
| not all((n in self.available) for n in node.all_input_nodes) | ||
| or node.op == "output" | ||
| or (node.is_impure() and self.inner_count > 0) |
Contributor
There was a problem hiding this comment.
Do we have a test for the issue this is fixing?
Contributor
Author
There was a problem hiding this comment.
test_distributed.py has a test covering this case
shunting314
commented
Mar 26, 2026
| fixed_config = helion.Config( | ||
| block_sizes=[8], | ||
| num_warps=8, | ||
| block_sizes=[8], num_warps=8, reduction_loops=[1024] |
Contributor
Author
There was a problem hiding this comment.
@jansel this test covered the issue fixed.
shunting314
force-pushed
the
shunting314/stack/18
branch
from
4d2178a to
3cecf1e
Compare
shunting314
force-pushed
the
shunting314/stack/18
branch
from
3cecf1e to
1724043
Compare
stack-info: PR: #1797, branch: shunting314/stack/18
shunting314
force-pushed
the
shunting314/stack/18
branch
from
1724043 to
c5a7440
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
properly codegen hl.triton_kernel
fix #1642 . When we roll reductions, we need consider side-effect of a node. We can not lift the node out of a loop if it has side effect. Instead, we should close the current loop, codegen the side-effect node and start a new loop.