Skip to content

Apply color scheme of EnhancedVolcano to plotly volcano#268

Merged
SusiJo merged 2 commits intoqbic-pipelines:devfrom
SusiJo:color_volcano
May 7, 2025
Merged

Apply color scheme of EnhancedVolcano to plotly volcano#268
SusiJo merged 2 commits intoqbic-pipelines:devfrom
SusiJo:color_volcano

Conversation

@SusiJo
Copy link
Copy Markdown
Collaborator

@SusiJo SusiJo commented May 6, 2025

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@SusiJo
Copy link
Copy Markdown
Collaborator Author

SusiJo commented May 6, 2025

Screenshot 2025-05-06 at 14 51 39

Copy link
Copy Markdown

@famosab famosab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@qbicStefanC
Copy link
Copy Markdown
Collaborator

Hi @SusiJo ,
isn't that wrong, and should be like this thus blue= p adj < 0.05 and green = logFC >1|<-1?
Screenshot 2025-05-07 at 10 14 25

@SusiJo SusiJo merged commit e35d203 into qbic-pipelines:dev May 7, 2025
15 of 16 checks passed
SusiJo added a commit to SusiJo/rnadeseq that referenced this pull request May 7, 2025
@SusiJo
Copy link
Copy Markdown
Collaborator Author

SusiJo commented May 7, 2025

@qbicStefanC: I will investigate and fix this. Sorry!

@SusiJo SusiJo mentioned this pull request May 8, 2025
9 tasks
@famosab
Copy link
Copy Markdown

famosab commented May 8, 2025

Sorry I only checked the coding part not the explicit plot result (as thats not my expertise) 🤔

@SusiJo SusiJo deleted the color_volcano branch May 30, 2025 09:24
SusiJo added a commit that referenced this pull request Jul 3, 2025
* Add EnhancedVolcano (#267)

* add enh. volcano

* update docu

* add comment

* rm comments, add omitNa

* ch version to dev

* add volcano to tests

* fix deprecated key-value

* update docs,changelog

* prettier test rsem profile

* fix contrast names

* Apply color scheme of EnhancedVolcano to plotly volcano (#268)

* add colors to plotly volcano

* add color scale

* Hotfix colors volcano plot (#271)

* hotfix switch volcano colors

* fix colors

* add abs, rm space

* rm "feature" text

* update titles, legends

* add subtitle for interactive plot

* ch y-axis label

* rm outcommented lines

* Put gprofiler in tabs (#270)

* put gprofiler in tabs

* revert

* linting

* trim whitespace

* mod plot title

* Bugfixes pathway analysis (#273)

* raise max dimensions limit

* concat ensembl ids with gene names

* update changelog & usage

update changelog & usage

update changelog & usage

Co-authored-by: Famke Bäuerle <45968370+famosab@users.noreply.github.com>

fix typo

* Update report (#275)

* change report name

* modify report

* update report & tests & fix volcano colors

* add to changelog, references

* fix citation

* fix df RIN

* fix linting & ci

* fix padding

* update md5sums due to sampleNames

* apply suggestions

* update confs

* apply suggestion

* add num all genes

* change icon

* adjust docs text

* Incorporate Feedback and fix typos (#276)

* incorporate feedback

* update report

* fix typos

* update changelog

* fix pre-commit

* fix spaces

* fix colored cells

* linting

* fix typos

* adjust table border

* fix typos

* apply suggestions

* apply suggestions

* Bugfix summary  (#278)

* fix contrast

* update usage

* add to changelog

* update test

* PR num

* ch md5sum

* Add gene biotypes to interactive volcano plots   (#272)

* adjust md5sums due to gtf biotypes

* update branch

* fix assignment

* add biotype to final DE table

* update md5sums

* version bump to 2.6 (#277)

* update branch.yml

* apply suggestion lint

* add to ignore

* update branch.yml

* test docker download

* rm pull_request_target rule

* update branch protection

* update branch protection

* update branch protection

* revert branch yml

* update branch yml

* test download

* test update

* update branch.yml

* change publishdir mode

* update version test

* Bugfix volcano (#280)

* fix thresholds in enhanced volcano

* add to changelog

* Prettify long contrast names in plot titles (#281)

* prettify long contrast names in plot titles

* add new test profile but not for ci

* rename files

* correct pr nums

* apply suggestions (#282)

* update env name

* revert download.yml

* test apptainer

* change order

* revert download.yml

* revert cachedir

* update md5sum

* Modify input base (#283)

* switch back to githubusercontent

* add to changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants