Skip to content

Bugfixes pathway analysis#273

Merged
SusiJo merged 3 commits intoqbic-pipelines:devfrom
SusiJo:bugfix_ggsave_gprofiler
May 14, 2025
Merged

Bugfixes pathway analysis#273
SusiJo merged 3 commits intoqbic-pipelines:devfrom
SusiJo:bugfix_ggsave_gprofiler

Conversation

@SusiJo
Copy link
Copy Markdown
Collaborator

@SusiJo SusiJo commented May 9, 2025

PR checklist

Fixes the ggsave error when many genes are DE.
With many genes being DE, one might need to adapt resource requirements.
Therefore, usage docs were updated to better document what to do in case of 137 error (OOM-out of memory).

  Quitting from lines 1936-2369 [load_PA_libs] (RNAseq_report.Rmd)
  Error:
  ! One or both dimensions exceed the maximum (50000px).
  - Use `options(ragg.max_dim = ...)` to change the max
    Warning: May cause the R session to crash
  Backtrace:
   1. ggplot2::ggsave(...)
   2. ggplot2 (local) dev(...)
   3. ggplot2 (local) png_dev(..., res = dpi, units = "in")
   4. ragg (local) f(...)
   5. ragg:::get_dims(width, height, units, res)
  Execution halted

Fixes the duplicate row.names error due to duplicate gene_names. Solved by concatenating Ensembl_ID_gene_name.

  Quitting from lines 2150-2607 [load_PA_libs] (RNAseq_report.Rmd)
  Error in `.rowNamesDF<-`:
  ! duplicate 'row.names' are not allowed
  Backtrace:
      ▆
   1. ├─base::`rownames<-`(`*tmp*`, value = mat$gene_name)
   2. └─base::`rownames<-`(`*tmp*`, value = mat$gene_name)
   3.   ├─base::`row.names<-`(`*tmp*`, value = value)
   4.   └─base::`row.names<-.data.frame`(`*tmp*`, value = value)
   5.     └─base::`.rowNamesDF<-`(x, value = value)
  Execution halted

Ensembl_ID_gene_name string can be split afterwards to filter out duplicates if desired.

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@famosab
Copy link
Copy Markdown

famosab commented May 12, 2025

Linting fails probably because you need to update to the latest template :)

@famosab
Copy link
Copy Markdown

famosab commented May 12, 2025

I am not so familiar with R but the changes seem to be fine just coding / guideline wise :)

Comment thread docs/usage.md
Comment thread docs/usage.md
@SusiJo
Copy link
Copy Markdown
Collaborator Author

SusiJo commented May 13, 2025

Linting fails probably because you need to update to the latest template :)

Yes, that would solve the linting issue. However, we will move to the nf-core/differentialabundance pipeline soon which makes the template update obsolete. These changes are implemented to prepare a last release with some bugfixes.

SusiJo added 3 commits May 13, 2025 11:02
update changelog & usage

update changelog & usage

Co-authored-by: Famke Bäuerle <45968370+famosab@users.noreply.github.com>

fix typo
@SusiJo SusiJo force-pushed the bugfix_ggsave_gprofiler branch from 8d32f82 to 9a08ad3 Compare May 13, 2025 09:04
Copy link
Copy Markdown

@famosab famosab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@SusiJo
Copy link
Copy Markdown
Collaborator Author

SusiJo commented May 14, 2025

@famosab thanks for reviewing!

@SusiJo SusiJo merged commit 16d5e38 into qbic-pipelines:dev May 14, 2025
15 of 16 checks passed
@SusiJo SusiJo deleted the bugfix_ggsave_gprofiler branch May 30, 2025 09:23
SusiJo added a commit that referenced this pull request Jul 3, 2025
* Add EnhancedVolcano (#267)

* add enh. volcano

* update docu

* add comment

* rm comments, add omitNa

* ch version to dev

* add volcano to tests

* fix deprecated key-value

* update docs,changelog

* prettier test rsem profile

* fix contrast names

* Apply color scheme of EnhancedVolcano to plotly volcano (#268)

* add colors to plotly volcano

* add color scale

* Hotfix colors volcano plot (#271)

* hotfix switch volcano colors

* fix colors

* add abs, rm space

* rm "feature" text

* update titles, legends

* add subtitle for interactive plot

* ch y-axis label

* rm outcommented lines

* Put gprofiler in tabs (#270)

* put gprofiler in tabs

* revert

* linting

* trim whitespace

* mod plot title

* Bugfixes pathway analysis (#273)

* raise max dimensions limit

* concat ensembl ids with gene names

* update changelog & usage

update changelog & usage

update changelog & usage

Co-authored-by: Famke Bäuerle <45968370+famosab@users.noreply.github.com>

fix typo

* Update report (#275)

* change report name

* modify report

* update report & tests & fix volcano colors

* add to changelog, references

* fix citation

* fix df RIN

* fix linting & ci

* fix padding

* update md5sums due to sampleNames

* apply suggestions

* update confs

* apply suggestion

* add num all genes

* change icon

* adjust docs text

* Incorporate Feedback and fix typos (#276)

* incorporate feedback

* update report

* fix typos

* update changelog

* fix pre-commit

* fix spaces

* fix colored cells

* linting

* fix typos

* adjust table border

* fix typos

* apply suggestions

* apply suggestions

* Bugfix summary  (#278)

* fix contrast

* update usage

* add to changelog

* update test

* PR num

* ch md5sum

* Add gene biotypes to interactive volcano plots   (#272)

* adjust md5sums due to gtf biotypes

* update branch

* fix assignment

* add biotype to final DE table

* update md5sums

* version bump to 2.6 (#277)

* update branch.yml

* apply suggestion lint

* add to ignore

* update branch.yml

* test docker download

* rm pull_request_target rule

* update branch protection

* update branch protection

* update branch protection

* revert branch yml

* update branch yml

* test download

* test update

* update branch.yml

* change publishdir mode

* update version test

* Bugfix volcano (#280)

* fix thresholds in enhanced volcano

* add to changelog

* Prettify long contrast names in plot titles (#281)

* prettify long contrast names in plot titles

* add new test profile but not for ci

* rename files

* correct pr nums

* apply suggestions (#282)

* update env name

* revert download.yml

* test apptainer

* change order

* revert download.yml

* revert cachedir

* update md5sum

* Modify input base (#283)

* switch back to githubusercontent

* add to changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants