fix: provide the way to override url protocol for the downstream build#1130
Merged
dgolovin merged 1 commit intoredhat-developer:mainfrom Apr 16, 2026
Merged
Conversation
While there is the way to provide different name for protocol handler installation and protocol, so it is not hardcoded anymore, it is useless for downstream until new API is published. This fix provides workaround to configure new url protocol for specific downstream build. Signed-off-by: Denis Golovin <dgolovin@redhat.com>
podman-desktop-triager
bot
added
domain/redhat-account/reviewed
and removed
domain/redhat-account/inreview
labels
dgolovin
changed the title
cdrage
reviewed
Apr 16, 2026
| process.exit(1); | ||
| } | ||
| const content = fs.readFileSync(successHtmlPath, 'utf8'); | ||
| const updated = content.replaceAll('podman-desktop', urlProtocol); |
Member
There was a problem hiding this comment.
I find it odd that this is ctrl+f ctrl+r podman-desktop through it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While there is the way to provide different name for protocol handler installation and protocol, so it is not hardcoded anymore, it is useless for downstream until new API is published. This fix provides workaround to configure new url protocol for specific downstream build.