Cannot create component from workspace folder when workspace is empty

[sbouchet]

Hi,
using VSCode 1.36.0 on RHEL 8, i cannot create a component from a folder. the dialog asking for the choice of source ( git / binary / folder ) is ok, selecting git is ok, but when selecting folder, i never see the folder selction dialog showing up.
debugging indicates 'folder' as undefined in

vscode-openshift-tools/src/openshift/component.ts

Line 248 in 0b561ac

if (!folder) return null;

[mohitsuman]

@sbouchet this uses the latest version of the extension, right ?

[sbouchet]

yes, 0.0.23, running debug from master branch

[sbouchet]

@mohitsuman : seems that after a restart the wizard now works correctly.
I changed the workspace in the meantime, so maybe it's just a matter of rising an error if there is no workspace correctly set ?

[sbouchet]

@mohitsuman : i can reproduce easily by :

• closing all editor and folders ( 'no folder opened' label in the explorer )

• trying to create a component from directory. --> no error, nothing happens.

• open a folder in the explorer

• trying to create a component from directory --> shows the folder selected step before.

[mohitsuman]

@sbouchet If you select the option Select the target workspace folder, it will show the list of folders available in the dropdown menu. Can you add any screengrab for the error ?

[sbouchet]

Yes, that works only if a already have a workspace folder selected, this is the normal behaviour :
step 1 : asking the component source

step 2 : when selecting folder :

the error is when there is no workspace folder opened --> no error, no folder selection shown ( no step 2 )

[mohitsuman]

@sbouchet oh okay. I got the error. We need to add options for the user to select a folder and add to workspace option here. Nice catch :)