provide context folder if no workspace present#950
Merged
mohitsuman merged 3 commits intoredhat-developer:masterfrom Jul 25, 2019
Merged
provide context folder if no workspace present#950mohitsuman merged 3 commits intoredhat-developer:masterfrom
mohitsuman merged 3 commits intoredhat-developer:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #950 +/- ##
==========================================
- Coverage 87.43% 87.37% -0.06%
==========================================
Files 28 28
Lines 1846 1854 +8
Branches 313 317 +4
==========================================
+ Hits 1614 1620 +6
- Misses 232 234 +2
Continue to review full report at Codecov.
|
dgolovin
requested changes
Jul 23, 2019
Collaborator
dgolovin
left a comment
dgolovin
left a comment
There was a problem hiding this comment.
We should stick to the same strategy we have for cluster url, login and password. There should be + Select folder from local file system item in the list to allow add new folder to workspace.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #923 #951