Using vscode api to open url in browser [WIP]

[sudhirverma]

Fix: #1249

[codecov]

Codecov Report

Merging #1251 into master will decrease coverage by 0.14%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master    #1251      +/-   ##
==========================================
- Coverage    85.8%   85.66%   -0.15%     
==========================================
  Files          32       32              
  Lines        2255     2253       -2     
  Branches      401      401              
==========================================
- Hits         1935     1930       -5     
- Misses        320      323       +3

Impacted Files	Coverage Δ
src/openshift/cluster.ts	100% <100%> (ø)	⬆️
src/openshift/url.ts	98.03% <100%> (-0.04%)	⬇️
src/openshift/component.ts	93.54% <100%> (+0.01%)	⬆️
src/odo.ts	79.4% <50%> (-0.04%)	⬇️
src/tools.ts	93.9% <50%> (ø)	⬆️
src/util/watch.ts	86.2% <0%> (-10.35%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 984f337...47c9972. Read the comment docs.

[mohitsuman]

I think env.openExternal is not getting stubbed in sinon and hence the tests are failing. And for linux the tests never terminates. @dgolovin can you have a look here.

[sudhirverma]

Closing this PR. As fixed in #1254