Skip to content

use vscode open command instead of open module for external links#1254

Merged
mohitsuman merged 3 commits intoredhat-developer:masterfrom
mohitsuman:gh-1249-fix
Oct 31, 2019
Merged

use vscode open command instead of open module for external links#1254
mohitsuman merged 3 commits intoredhat-developer:masterfrom
mohitsuman:gh-1249-fix

Conversation

@mohitsuman
Copy link
Copy Markdown
Contributor

Fix #1249

@mohitsuman mohitsuman requested a review from jrichter1 October 31, 2019 15:30
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 31, 2019

Codecov Report

Merging #1254 into master will decrease coverage by 0.38%.
The diff coverage is 28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1254      +/-   ##
==========================================
- Coverage    85.8%   85.42%   -0.39%     
==========================================
  Files          32       32              
  Lines        2255     2257       +2     
  Branches      401      401              
==========================================
- Hits         1935     1928       -7     
- Misses        320      329       +9
Impacted Files Coverage Δ
src/odo.ts 79.4% <0%> (-0.04%) ⬇️
src/k8s/console.ts 13.55% <0%> (-3.75%) ⬇️
src/tools.ts 93.82% <0%> (-0.08%) ⬇️
src/openshift/cluster.ts 100% <100%> (ø) ⬆️
src/openshift/component.ts 93.51% <100%> (-0.02%) ⬇️
src/openshift/url.ts 96.07% <100%> (-2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 984f337...313a5d3. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rely on 'vscode.env.openExternal' API instead of 3'd party lib

2 participants