Skip to content

Update oc command parsing to extract correct cluster url and token#2300

Merged
dgolovin merged 1 commit intoredhat-developer:masterfrom
dgolovin:i1967-login-to-cluster-using-info-in-clipboard
Nov 23, 2021
Merged

Update oc command parsing to extract correct cluster url and token#2300
dgolovin merged 1 commit intoredhat-developer:masterfrom
dgolovin:i1967-login-to-cluster-using-info-in-clipboard

Conversation

@dgolovin
Copy link
Copy Markdown
Collaborator

This PR fixes #1967.

Signed-off-by: Denis Golovin dgolovin@redhat.com

This PR fixes redhat-developer#1967.

Signed-off-by: Denis Golovin dgolovin@redhat.com
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 23, 2021

Codecov Report

Merging #2300 (9483b13) into master (30453ed) will decrease coverage by 0.03%.
The diff coverage is 56.25%.

❗ Current head 9483b13 differs from pull request most recent head 3efb683. Consider uploading reports for the commit 3efb683 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2300      +/-   ##
==========================================
- Coverage   70.30%   70.26%   -0.04%     
==========================================
  Files          52       52              
  Lines        3421     3430       +9     
  Branches      630      632       +2     
==========================================
+ Hits         2405     2410       +5     
- Misses       1016     1020       +4     
Impacted Files Coverage Δ
src/openshift/cluster.ts 83.00% <46.15%> (-2.79%) ⬇️
src/openshift/openshiftItem.ts 82.91% <100.00%> (+1.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30453ed...3efb683. Read the comment docs.

@dgolovin dgolovin merged commit af806de into redhat-developer:master Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add quickpick item 'Login using cluster URL and token from clipboard' to login command

1 participant