Edit option for registry#2424
Merged
dgolovin merged 7 commits intoredhat-developer:mainfrom May 19, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2424 +/- ##
==========================================
- Coverage 66.92% 66.63% -0.29%
==========================================
Files 55 55
Lines 3562 3585 +23
Branches 637 647 +10
==========================================
+ Hits 2384 2389 +5
- Misses 1178 1196 +18
Continue to review full report at Codecov.
|
Contributor
|
I think this PR needs to be rebased after the webview UI PR #2396 is merged to the main. |
dgolovin
requested changes
May 17, 2022
dgolovin
requested changes
May 18, 2022
Collaborator
dgolovin
left a comment
dgolovin
left a comment
There was a problem hiding this comment.
The current approach is good, but issues with validation should be fixed.
Signed-off-by: Denis Golovin dgolovin@redhat.com
dgolovin
previously requested changes
May 18, 2022
Collaborator
dgolovin
left a comment
dgolovin
left a comment
There was a problem hiding this comment.
Look at msivasubramaniaan#2.
Signed-off-by: Denis Golovin dgolovin@redhat.com
dgolovin
approved these changes
May 19, 2022
Collaborator
dgolovin
left a comment
dgolovin
left a comment
There was a problem hiding this comment.
It works as expected now (see my commits and animated gif added to the issue)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR helps to updating the registry name and URL
Ref: #2415