Edit option for registry

package.json

@@ -263,6 +263,7 @@
 		"onCommand:openshift.component.watch.terminate",
 		"onCommand:openshift.component.watch.showLog",
 		"onCommand:openshift.component.deployRootWorkspaceFolder",
+		"onCommand:openshift.componentTypesView.registry.closeView",
 		"onCommand:openshift.catalog.listComponents",
 		"onCommand:openshift.catalog.listServices",
 		"onCommand:openshift.url.create",
@@ -873,6 +874,11 @@
 				"title": "Remove",
 				"category": "OpenSift"
 			},
+			{
+				"command": "openshift.componentTypesView.registry.edit",
+				"title": "Edit",
+				"category": "OpenSift"
+			},
 			{
 				"command": "openshift.componentTypesView.registry.openInBrowser",
 				"title": "Open in Browser",
@@ -1159,6 +1165,10 @@
 					"command": "openshift.componentTypesView.registry.remove",
 					"when": "false"
 				},
+				{
+					"command": "openshift.componentTypesView.registry.edit",
+					"when": "false"
+				},
 				{
 					"command": "openshift.componentTypesView.registry.openInView",
 					"when": "false"
@@ -1549,6 +1559,11 @@
 					"command": "openshift.component.revealInExplorer",
 					"when": "view == openshiftComponentsView && viewItem == openshift.component"
 				},
+				{
+					"command": "openshift.componentTypesView.registry.edit",
+					"when": "view == openshiftComponentTypesView && viewItem == devfileRegistry && viewItem != DefaultdevfileRegistry",
+					"group": "1@0"
+				},
 				{
 					"command": "openshift.componentTypesView.registry.remove",
 					"when": "view == openshiftComponentTypesView && viewItem == devfileRegistry && viewItem != DefaultdevfileRegistry",

src/componentTypesView.ts

@@ -2,7 +2,7 @@
  *  Copyright (c) Red Hat, Inc. All rights reserved.
  *  Licensed under the MIT License. See LICENSE file in the project root for license information.
  *-----------------------------------------------------------------------------------------------*/
-
+import * as vscode from 'vscode';
 import {
     TreeDataProvider,
     TreeItem,
@@ -173,10 +173,11 @@ export class ComponentTypesView implements TreeDataProvider<ComponentType> {
     }
 
     @vsCommand('openshift.componentTypesView.registry.add')
-    public static async addRegistryCmd(): Promise<void> {
+    public static async addRegistryCmd(registryContext: Registry): Promise<void> {
         // ask for registry
         const regName = await window.showInputBox({
-            prompt: 'Provide registry name to display in the view',
+            value: registryContext?.Name,
+            prompt: registryContext ? 'Edit registry name' : 'Provide registry name to display in the view',
             placeHolder: 'Registry Name',
             validateInput: async (value) => {
                 const trimmedValue = value.trim();
@@ -197,15 +198,16 @@ export class ComponentTypesView implements TreeDataProvider<ComponentType> {
 
         const regURL = await window.showInputBox({
             ignoreFocusOut: true,
-            prompt: 'Provide registry URL to display in the view',
+            value: registryContext?.URL,
+            prompt: registryContext ? 'Edit registry URL' : 'Provide registry URL to display in the view',
             placeHolder: 'Registry URL',
             validateInput: async (value) => {
                 const trimmedValue = value.trim();
                 if (!validator.isURL(trimmedValue)) {
                     return 'Entered URL is invalid';
                 }
                 const registries = await ComponentTypesView.instance.getRegistries();
-                if (registries.find((registry) => registry.URL === value)) {
+                if (!registryContext && registries.find((registry) => registry.URL === value)) {
                     return `Registry with entered URL '${value}' already exists`;
                 }
             },
@@ -230,8 +232,8 @@ export class ComponentTypesView implements TreeDataProvider<ComponentType> {
     }
 
     @vsCommand('openshift.componentTypesView.registry.remove')
-    public static async removeRegistry(registry: Registry): Promise<void> {
-        const yesNo = await window.showInformationMessage(
+    public static async removeRegistry(registry: Registry, isEdit?: boolean): Promise<void> {
+        const yesNo = isEdit ? 'Yes' : await window.showInformationMessage(
             `Remove registry '${registry.Name}'?`,
             'Yes',
             'No',
@@ -242,6 +244,16 @@ export class ComponentTypesView implements TreeDataProvider<ComponentType> {
         }
     }
 
+    @vsCommand('openshift.componentTypesView.registry.edit')
+    public static async editRegistry(registry: Registry): Promise<void> {
+        await vscode.commands.executeCommand('openshift.componentTypesView.registry.closeView');
+        const addRegistryFlag = await vscode.commands.executeCommand('openshift.componentTypesView.registry.add', registry);
+        if (null !== addRegistryFlag) {
+            await vscode.commands.executeCommand('openshift.componentTypesView.registry.remove', registry, true);
+            vscode.commands.executeCommand('openshift.componentTypesView.registry.openInView');
+        }
+    }
+
     @vsCommand('openshift.componentTypesView.registry.openInBrowser')
     public static async openRegistryWebSite(registry: Registry): Promise<void> {
         await commands.executeCommand('vscode.open', Uri.parse(registry.URL));

src/extension.ts

@@ -77,7 +77,8 @@ export async function activate(extensionContext: ExtensionContext): Promise<any>
             './k8s/console',
             './oc',
             './componentTypesView',
-            './componentsView'
+            './componentsView',
+            './webview/devfile-registry/registryViewLoader'
         )),
         commands.registerCommand('clusters.openshift.useProject', (context) =>
             commands.executeCommand('extension.vsKubernetesUseNamespace', context),

src/webview/devfile-registry/registryViewLoader.ts

@@ -12,6 +12,7 @@ import { stringify } from 'yaml';
 import { ComponentTypesView } from '../../componentTypesView';
 import { StarterProject } from '../../odo/componentTypeDescription';
 import { DevfileComponentType } from '../../odo/componentType';
+import { vsCommand } from '../../vscommand';
 
 let panel: vscode.WebviewPanel;
 let compDescriptions = new Set<any>();
@@ -85,7 +86,6 @@ async function devfileRegistryViewerMessageListener(event: any): Promise<any> {
             break;
     }
 }
-
 export default class RegistryViewLoader {
     // eslint-disable-next-line @typescript-eslint/explicit-function-return-type
     static get extensionPath() {
@@ -135,4 +135,9 @@ export default class RegistryViewLoader {
             .replace('%BASE_URL%', `${reactAppUri}`)
             .replace('<!-- meta http-equiv="Content-Security-Policy" -->', meta);
     }
+
+    @vsCommand('openshift.componentTypesView.registry.closeView')
+    static async closeRegistryInWebview(): Promise<void> {
+        panel?.dispose();
+    }
 }