-
Notifications
You must be signed in to change notification settings - Fork 60
Create get started page for OpenShift in VSCode Open walkthrough #2441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mohitsuman
merged 31 commits into
redhat-developer:main
from
msivasubramaniaan:2414-create-get-started-for-openshift-in-vscode-open-walkthrough
Jun 16, 2022
Merged
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
52a7824
added walthrough in package.json
msivasubramaniaan 9eecf00
Merge branch 'main' into 2414-create-get-started-for-openshift-in-vsc…
msivasubramaniaan 26849f3
added steps on the walkthrough
msivasubramaniaan 3092b6c
Merge branch 'main' into 2414-create-get-started-for-openshift-in-vsc…
msivasubramaniaan 36d3e1f
changed title and description of the steps
msivasubramaniaan 7c58658
Merge branch 'main' into 2414-create-get-started-for-openshift-in-vsc…
msivasubramaniaan f3b4824
added additional login option and post corresponding message
msivasubramaniaan ff0171c
Update login description in package.json
msivasubramaniaan 10fdbcd
Update debug description in package.json
msivasubramaniaan 937c83d
Update login title in package.json
msivasubramaniaan fe2c009
added show registry step and updated the gifs
msivasubramaniaan b05ccb8
Merge branch '2414-create-get-started-for-openshift-in-vscode-open-wa…
msivasubramaniaan 376099d
used the exisiting message passing
msivasubramaniaan bc7ce64
Update open browser desc package.json
msivasubramaniaan d3357d1
Update create component desc package.json
msivasubramaniaan 9ac4978
Update push component desc package.json
msivasubramaniaan f3968cd
updated desc and gifs
msivasubramaniaan 8dd7f57
updated desc of show registries
msivasubramaniaan 1de2189
added openInView into onCommand for makes the step get completes
msivasubramaniaan 94ff9d5
Update the main desc package.json
msivasubramaniaan fba0856
Update the login desc package.json
msivasubramaniaan 47c7ed6
Update the show registry desc package.json
msivasubramaniaan 009b39f
updated the vscode-openshift-tools.gif
msivasubramaniaan 41c7c99
updated the vscode-openshift-tools.gif
msivasubramaniaan 13fce0f
Merge branch '2414-create-get-started-for-openshift-in-vscode-open-wa…
msivasubramaniaan 83b868e
reverted the gif
msivasubramaniaan 84c91d9
Merge branch 'main' into 2414-create-get-started-for-openshift-in-vsc…
msivasubramaniaan 355d406
change login title and desc
msivasubramaniaan 5e88ae8
Add activation event and Provision OpenShift cluster button
dgolovin da906a2
Revert "Add activation event and Provision OpenShift cluster button"
dgolovin be5d77c
Rename 'Connect using ...' to 'Provision ...'
dgolovin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This step does not look right to me. Login is just a way to get access to cluster resources and it does not matter how cluster is provisioned or where it is located.
What I see is attempt to mix cluster login, provisioning and location in one step.
I suggest to bubble up one more step. 'Get access to OpenShift cluster' or 'Provision or use existing OpenShift cluster'
Where we can have button to open 'Add Cluster Editor'. Then reduce Login step to just a description and login button.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed the login title and description. Please refer the screenshot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this covers the use case of differentiating the Login and provision workflow. The description also works for me. LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, it is still two questions answered in one step.
'Connect using OpenShift Local' sounds awkward to me, I would say 'Connect using ssh' or 'Connect to OpenShift using SSH'. Both sounds good to me. Lets try 'Connect to OpenShift Using OpenShift Local' does that sound good? It is not for me.
IMHO first someone who is interested would ask where/how one can get OpenShift instance? Then ask how to work with it or see what is in it through the UI elements provided by extension they've just installed and that would require to log into the cluster.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here OpenShift local refers to renamed CodeReadyContainers. So connect using OpenShift local should open the CRC view we currently have.