Create get started page for OpenShift in VSCode Open walkthrough by msivasubramaniaan · Pull Request #2441 · redhat-developer/vscode-openshift-tools

msivasubramaniaan · 2022-05-31T09:13:26Z

Added Walkthrough steps for the extension

…ode-open-walkthrough

codecov · 2022-05-31T09:17:17Z

Codecov Report

Merging #2441 (be5d77c) into main (ccc7750) will decrease coverage by 0.03%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##             main    #2441      +/-   ##
==========================================
- Coverage   66.62%   66.58%   -0.04%     
==========================================
  Files          55       55              
  Lines        3583     3585       +2     
  Branches      647      648       +1     
==========================================
  Hits         2387     2387              
- Misses       1196     1198       +2

Impacted Files	Coverage Δ
src/openshift/cluster.ts	`80.97% <40.00%> (-0.80%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccc7750...be5d77c. Read the comment docs.

…ode-open-walkthrough

Co-authored-by: Mohit Suman <mohit.skn@gmail.com>

…lkthrough' of https://github.com/msivasubramaniaan/vscode-openshift-tools into 2414-create-get-started-for-openshift-in-vscode-open-walkthrough

mohitsuman

@msivasubramaniaan Please update the descriptions accordingly as per the suggestions. We also need to update with the zoom in gifs for every step.

Co-authored-by: Mohit Suman <mohit.skn@gmail.com>

mohitsuman · 2022-06-02T12:26:26Z

@msivasubramaniaan the gifs looks good to me. Just commit the suggested changes.

Co-authored-by: Mohit Suman <mohit.skn@gmail.com>

mohitsuman

LGTM

…lkthrough' of https://github.com/msivasubramaniaan/vscode-openshift-tools into 2414-create-get-started-for-openshift-in-vscode-open-walkthrough

dgolovin · 2022-06-02T18:43:02Z

+                "description": "Start your application development on OpenShift or Kubernetes",
+                "steps": [
+                    {
+                        "id": "login",


This step does not look right to me. Login is just a way to get access to cluster resources and it does not matter how cluster is provisioned or where it is located.

What I see is attempt to mix cluster login, provisioning and location in one step.

I suggest to bubble up one more step. 'Get access to OpenShift cluster' or 'Provision or use existing OpenShift cluster'
Where we can have button to open 'Add Cluster Editor'. Then reduce Login step to just a description and login button.

Changed the login title and description. Please refer the screenshot

I think this covers the use case of differentiating the Login and provision workflow. The description also works for me. LGTM.

Well, it is still two questions answered in one step.

'Connect using OpenShift Local' sounds awkward to me, I would say 'Connect using ssh' or 'Connect to OpenShift using SSH'. Both sounds good to me. Lets try 'Connect to OpenShift Using OpenShift Local' does that sound good? It is not for me.

IMHO first someone who is interested would ask where/how one can get OpenShift instance? Then ask how to work with it or see what is in it through the UI elements provided by extension they've just installed and that would require to log into the cluster.

Here OpenShift local refers to renamed CodeReadyContainers. So connect using OpenShift local should open the CRC view we currently have.

…ode-open-walkthrough

dgolovin

Please, see my comment above.

Signed-off-by: Denis Golovin dgolovin@redhat.com

This reverts commit 5e88ae8.

Signed-off-by: Denis Golovin dgolovin@redhat.com

…hat-developer#2441) * added walthrough in package.json * added steps on the walkthrough * changed title and description of the steps * added additional login option and post corresponding message * Update login description in package.json Co-authored-by: Mohit Suman <mohit.skn@gmail.com> * Update debug description in package.json Co-authored-by: Mohit Suman <mohit.skn@gmail.com> * Update login title in package.json Co-authored-by: Mohit Suman <mohit.skn@gmail.com> * added show registry step and updated the gifs * used the exisiting message passing * Update open browser desc package.json Co-authored-by: Mohit Suman <mohit.skn@gmail.com> * Update create component desc package.json Co-authored-by: Mohit Suman <mohit.skn@gmail.com> * Update push component desc package.json Co-authored-by: Mohit Suman <mohit.skn@gmail.com> * updated desc and gifs * updated desc of show registries * added openInView into onCommand for makes the step get completes * Update the main desc package.json Co-authored-by: Mohit Suman <mohit.skn@gmail.com> * Update the login desc package.json Co-authored-by: Mohit Suman <mohit.skn@gmail.com> * Update the show registry desc package.json Co-authored-by: Mohit Suman <mohit.skn@gmail.com> * updated the vscode-openshift-tools.gif * updated the vscode-openshift-tools.gif * reverted the gif * change login title and desc * Add activation event and Provision OpenShift cluster button Signed-off-by: Denis Golovin dgolovin@redhat.com * Revert "Add activation event and Provision OpenShift cluster button" This reverts commit 5e88ae8. * Rename 'Connect using ...' to 'Provision ...' Signed-off-by: Denis Golovin dgolovin@redhat.com Co-authored-by: Mohit Suman <mohit.skn@gmail.com> Co-authored-by: Denis Golovin <dgolovin@redhat.com> Signed-off-by: msivasubramaniaan <msivasub@redhat.com>

msivasubramaniaan added 3 commits May 19, 2022 16:46

added walthrough in package.json

52a7824

Merge branch 'main' into 2414-create-get-started-for-openshift-in-vsc…

9eecf00

…ode-open-walkthrough

added steps on the walkthrough

26849f3

msivasubramaniaan requested review from dgolovin and mohitsuman May 31, 2022 09:13

msivasubramaniaan self-assigned this May 31, 2022

msivasubramaniaan linked an issue May 31, 2022 that may be closed by this pull request

Create Get Started for OpenShift in VSCode Open Walkthrough #2414

Closed

2 tasks

msivasubramaniaan added 4 commits June 1, 2022 10:28

Merge branch 'main' into 2414-create-get-started-for-openshift-in-vsc…

3092b6c

…ode-open-walkthrough

changed title and description of the steps

36d3e1f

Merge branch 'main' into 2414-create-get-started-for-openshift-in-vsc…

7c58658

…ode-open-walkthrough

added additional login option and post corresponding message

f3b4824

mohitsuman changed the title ~~Create get started page for open shift in vscode open walkthrough~~ Create get started page for OpenShift in VSCode Open walkthrough Jun 1, 2022

mohitsuman reviewed Jun 1, 2022

View reviewed changes

Comment thread package.json Outdated

mohitsuman reviewed Jun 1, 2022

View reviewed changes

Comment thread package.json Outdated

mohitsuman reviewed Jun 2, 2022

View reviewed changes

Comment thread package.json Outdated

mohitsuman reviewed Jun 2, 2022

View reviewed changes

Comment thread package.json Outdated

msivasubramaniaan and others added 6 commits June 2, 2022 12:47

Update login description in package.json

ff0171c

Co-authored-by: Mohit Suman <mohit.skn@gmail.com>

Update debug description in package.json

10fdbcd

Co-authored-by: Mohit Suman <mohit.skn@gmail.com>

Update login title in package.json

937c83d

Co-authored-by: Mohit Suman <mohit.skn@gmail.com>

added show registry step and updated the gifs

fe2c009

Merge branch '2414-create-get-started-for-openshift-in-vscode-open-wa…

b05ccb8

…lkthrough' of https://github.com/msivasubramaniaan/vscode-openshift-tools into 2414-create-get-started-for-openshift-in-vscode-open-walkthrough

used the exisiting message passing

376099d

mohitsuman reviewed Jun 2, 2022

View reviewed changes

Comment thread package.json Outdated

mohitsuman reviewed Jun 2, 2022

View reviewed changes

Comment thread package.json Outdated

mohitsuman reviewed Jun 2, 2022

View reviewed changes

Comment thread package.json Outdated

mohitsuman reviewed Jun 2, 2022

View reviewed changes

Comment thread package.json Outdated

mohitsuman suggested changes Jun 2, 2022

View reviewed changes

msivasubramaniaan and others added 2 commits June 2, 2022 14:15

Update open browser desc package.json

bc7ce64

Co-authored-by: Mohit Suman <mohit.skn@gmail.com>

Update create component desc package.json

d3357d1

Co-authored-by: Mohit Suman <mohit.skn@gmail.com>

msivasubramaniaan added 2 commits June 2, 2022 14:21

updated desc of show registries

8dd7f57

added openInView into onCommand for makes the step get completes

1de2189

msivasubramaniaan requested a review from mohitsuman June 2, 2022 09:52

mohitsuman reviewed Jun 2, 2022

View reviewed changes

Comment thread package.json Outdated

mohitsuman reviewed Jun 2, 2022

View reviewed changes

Comment thread package.json Outdated

mohitsuman reviewed Jun 2, 2022

View reviewed changes

Comment thread package.json Outdated

msivasubramaniaan and others added 3 commits June 2, 2022 17:57

Update the main desc package.json

94ff9d5

Co-authored-by: Mohit Suman <mohit.skn@gmail.com>

Update the login desc package.json

fba0856

Co-authored-by: Mohit Suman <mohit.skn@gmail.com>

Update the show registry desc package.json

47c7ed6

Co-authored-by: Mohit Suman <mohit.skn@gmail.com>

mohitsuman self-requested a review June 2, 2022 12:29

mohitsuman approved these changes Jun 2, 2022

View reviewed changes

msivasubramaniaan added 4 commits June 2, 2022 19:02

updated the vscode-openshift-tools.gif

009b39f

updated the vscode-openshift-tools.gif

41c7c99

Merge branch '2414-create-get-started-for-openshift-in-vscode-open-wa…

13fce0f

…lkthrough' of https://github.com/msivasubramaniaan/vscode-openshift-tools into 2414-create-get-started-for-openshift-in-vscode-open-walkthrough

reverted the gif

83b868e

dgolovin requested changes Jun 2, 2022

View reviewed changes

msivasubramaniaan added 2 commits June 8, 2022 10:45

Merge branch 'main' into 2414-create-get-started-for-openshift-in-vsc…

84c91d9

…ode-open-walkthrough

change login title and desc

355d406

dgolovin requested changes Jun 10, 2022

View reviewed changes

Add activation event and Provision OpenShift cluster button

5e88ae8

Signed-off-by: Denis Golovin dgolovin@redhat.com

dgolovin approved these changes Jun 15, 2022

View reviewed changes

Revert "Add activation event and Provision OpenShift cluster button"

da906a2

This reverts commit 5e88ae8.

dgolovin force-pushed the 2414-create-get-started-for-openshift-in-vscode-open-walkthrough branch from 0af18f3 to ae62748 Compare June 16, 2022 03:48

Rename 'Connect using ...' to 'Provision ...'

be5d77c

Signed-off-by: Denis Golovin dgolovin@redhat.com

dgolovin force-pushed the 2414-create-get-started-for-openshift-in-vscode-open-walkthrough branch from ae62748 to be5d77c Compare June 16, 2022 04:17

mohitsuman merged commit 84701b0 into redhat-developer:main Jun 16, 2022

msivasubramaniaan deleted the 2414-create-get-started-for-openshift-in-vscode-open-walkthrough branch June 20, 2022 09:54

dgolovin mentioned this pull request Jan 13, 2023

i2738 fix octogit dgolovin/vscode-openshift-tools#3

Open

Conversation

msivasubramaniaan commented May 31, 2022

Uh oh!

codecov bot commented May 31, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mohitsuman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mohitsuman commented Jun 2, 2022

Uh oh!

mohitsuman left a comment

Choose a reason for hiding this comment

Uh oh!

dgolovin Jun 2, 2022

Choose a reason for hiding this comment

Uh oh!

msivasubramaniaan Jun 10, 2022

Choose a reason for hiding this comment

Uh oh!

mohitsuman Jun 10, 2022

Choose a reason for hiding this comment

Uh oh!

dgolovin Jun 10, 2022

Choose a reason for hiding this comment

Uh oh!

mohitsuman Jun 11, 2022

Choose a reason for hiding this comment

Uh oh!

dgolovin left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov bot commented May 31, 2022 •

edited

Loading