-
Notifications
You must be signed in to change notification settings - Fork 60
Create get started page for OpenShift in VSCode Open walkthrough #2441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 7 commits
52a7824
9eecf00
26849f3
3092b6c
36d3e1f
7c58658
f3b4824
ff0171c
10fdbcd
937c83d
fe2c009
b05ccb8
376099d
bc7ce64
d3357d1
9ac4978
f3968cd
8dd7f57
1de2189
94ff9d5
fba0856
47c7ed6
009b39f
41c7c99
13fce0f
83b868e
84c91d9
355d406
5e88ae8
da906a2
be5d77c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -896,11 +896,6 @@ | |
| } | ||
| ], | ||
| "keybindings": [ | ||
| { | ||
| "command": "openshift.explorer.login", | ||
| "key": "alt+shift+l", | ||
| "mac": "ctrl+shift+l" | ||
| }, | ||
| { | ||
| "command": "openshift.explorer.refresh", | ||
| "key": "alt+shift+r", | ||
|
|
@@ -1561,6 +1556,69 @@ | |
| } | ||
| ] | ||
| }, | ||
| "walkthroughs": [ | ||
| { | ||
| "id": "openshiftWalkthrough", | ||
| "title": "Getting Started with OpenShift", | ||
| "description": "A sample walkthrough", | ||
| "steps": [ | ||
| { | ||
| "id": "login", | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This step does not look right to me. Login is just a way to get access to cluster resources and it does not matter how cluster is provisioned or where it is located. What I see is attempt to mix cluster login, provisioning and location in one step. I suggest to bubble up one more step. 'Get access to OpenShift cluster' or 'Provision or use existing OpenShift cluster'
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this covers the use case of differentiating the Login and provision workflow. The description also works for me. LGTM.
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Well, it is still two questions answered in one step. 'Connect using OpenShift Local' sounds awkward to me, I would say 'Connect using ssh' or 'Connect to OpenShift using SSH'. Both sounds good to me. Lets try 'Connect to OpenShift Using OpenShift Local' does that sound good? It is not for me. IMHO first someone who is interested would ask where/how one can get OpenShift instance? Then ask how to work with it or see what is in it through the UI elements provided by extension they've just installed and that would require to log into the cluster.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Here OpenShift local refers to renamed CodeReadyContainers. So connect using OpenShift local should open the CRC view we currently have. |
||
| "title": "Login to Openshift", | ||
|
msivasubramaniaan marked this conversation as resolved.
Outdated
|
||
| "description": "This step will helps with login to Openshift.\n[Connect using remote OpenShift Cluster](command:openshift.explorer.login)\n[Connect using OpenShift Local](command:openshift.explorer.addCluster?[\"crc\"])\n[Connect using Developer Sandbox](command:openshift.explorer.addCluster?[\"sandbox\"])", | ||
|
msivasubramaniaan marked this conversation as resolved.
Outdated
|
||
| "media": { | ||
| "image": "images/walkthrough/loginCluster.gif", | ||
| "altText": "login to cluster" | ||
| }, | ||
| "completionEvents": [ | ||
| "onCommand:openshift.explorer.login", | ||
| "onCommand:openshift.explorer.addCluster", | ||
| "onCommand:openshift.explorer.login.credentialsLogin", | ||
| "onCommand:openshift.explorer.login.tokenLogin" | ||
| ] | ||
| }, | ||
| { | ||
| "id": "createComponent", | ||
| "title": "Create a Component using Registry Viewer", | ||
| "description": "This step will run a command and check off once it has been run.\n[Create Component](command:openshift.componentType.newComponent)", | ||
|
msivasubramaniaan marked this conversation as resolved.
Outdated
|
||
| "media": { | ||
| "image": "images/walkthrough/createComponent.gif", | ||
| "altText": "create component" | ||
| }, | ||
| "completionEvents": [ | ||
| "onCommand:openshift.componentType.newComponent" | ||
| ] | ||
| }, | ||
| { | ||
| "id": "pushComponent", | ||
| "title": "Push a Component to the connected cluster", | ||
| "description": "This step will push the component into the cluster.", | ||
|
msivasubramaniaan marked this conversation as resolved.
Outdated
|
||
| "media": { | ||
| "image": "images/walkthrough/push.gif", | ||
| "altText": "push" | ||
| } | ||
| }, | ||
| { | ||
| "id": "debug", | ||
| "title": "Debug the Component locally", | ||
| "description": "This step helps to understand, debugging a component locally.", | ||
|
msivasubramaniaan marked this conversation as resolved.
Outdated
|
||
| "media": { | ||
| "image": "images/walkthrough/push.gif", | ||
| "altText": "push" | ||
| } | ||
| }, | ||
| { | ||
| "id": "openInBrowser", | ||
| "title": "Open the Component in Browser", | ||
| "description": "This step helps to understand, opening the component in browser.", | ||
|
msivasubramaniaan marked this conversation as resolved.
Outdated
|
||
| "media": { | ||
| "image": "images/walkthrough/push.gif", | ||
| "altText": "push" | ||
|
msivasubramaniaan marked this conversation as resolved.
Outdated
|
||
| } | ||
| } | ||
| ] | ||
| } | ||
| ], | ||
| "configuration": [ | ||
| { | ||
| "type": "object", | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| /*----------------------------------------------------------------------------------------------- | ||
| * Copyright (c) Red Hat, Inc. All rights reserved. | ||
| * Licensed under the MIT License. See LICENSE file in the project root for license information. | ||
| *-----------------------------------------------------------------------------------------------*/ | ||
|
|
||
| declare const acquireVsCodeApi: Function; | ||
|
|
||
| interface VSCodeApi { | ||
| getState: () => any; | ||
| setState: (newState: any) => any; | ||
| postMessage: (message: any) => void; | ||
| } | ||
|
|
||
| class VSCodeWrapper { | ||
| private readonly vscodeApi: VSCodeApi = acquireVsCodeApi(); | ||
|
|
||
| /** | ||
| * Send message to the extension framework. | ||
| * @param message | ||
| */ | ||
| public postMessage(message: any): void { | ||
| this.vscodeApi.postMessage(message); | ||
| } | ||
|
|
||
| /** | ||
| * Add listener for messages from extension framework. | ||
| * @param callback called when the extension sends a message | ||
| * @returns function to clean up the message eventListener. | ||
| */ | ||
| public onMessage(callback: (message: any) => void): () => void { | ||
| window.addEventListener('message', callback); | ||
| return () => window.removeEventListener('message', callback); | ||
| } | ||
| } | ||
|
|
||
| // Singleton to prevent multiple fetches of VsCodeAPI. | ||
| export const vscodeApi: VSCodeWrapper = new VSCodeWrapper(); |


Uh oh!
There was an error while loading. Please reload this page.