Skip to content

Remove experimental feature warning when running on podman#2807

Merged
dgolovin merged 3 commits intoredhat-developer:mainfrom
dgolovin:disable-experimental-features-for-podman-support
Mar 23, 2023
Merged

Remove experimental feature warning when running on podman#2807
dgolovin merged 3 commits intoredhat-developer:mainfrom
dgolovin:disable-experimental-features-for-podman-support

Conversation

@dgolovin
Copy link
Copy Markdown
Collaborator

@dgolovin dgolovin commented Mar 23, 2023

Fix #2812.
Related to redhat-developer/odo#6674.

Signed-off-by: Denis Golovin dgolovin@redhat.com

Signed-off-by: Denis Golovin dgolovin@redhat.com
Signed-off-by: Denis Golovin dgolovin@redhat.com
@dgolovin dgolovin force-pushed the disable-experimental-features-for-podman-support branch from e4f9d5c to c9f7612 Compare March 23, 2023 20:04
Signed-off-by: Denis Golovin dgolovin@redhat.com
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 23, 2023

Codecov Report

Patch coverage: 5.88% and project coverage change: +0.44 🎉

Comparison is base (895c510) 33.72% compared to head (331636a) 34.17%.

❗ Current head 331636a differs from pull request most recent head ac81aa7. Consider uploading reports for the commit ac81aa7 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2807      +/-   ##
==========================================
+ Coverage   33.72%   34.17%   +0.44%     
==========================================
  Files          70       70              
  Lines        4314     4302      -12     
  Branches      782      777       -5     
==========================================
+ Hits         1455     1470      +15     
+ Misses       2859     2832      -27     
Impacted Files Coverage Δ
src/odo/command.ts 14.28% <0.00%> (-0.28%) ⬇️
src/openshift/component.ts 15.21% <0.00%> (+0.51%) ⬆️
src/webview/log/LogViewLoader.ts 21.21% <0.00%> (+0.62%) ⬆️
src/tools.ts 88.88% <100.00%> (ø)

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dgolovin dgolovin merged commit 97f23a5 into redhat-developer:main Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

'Show Logs' and 'Follow logs' commands doesn't work when dev is running on podman

1 participant