Routinely check for a new version of odo.#2815
Merged
rgrunber merged 1 commit intoredhat-developer:mainfrom Apr 3, 2023
Merged
Routinely check for a new version of odo.#2815rgrunber merged 1 commit intoredhat-developer:mainfrom
rgrunber merged 1 commit intoredhat-developer:mainfrom
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2815 +/- ##
==========================================
+ Coverage 33.72% 34.17% +0.44%
==========================================
Files 70 70
Lines 4314 4302 -12
Branches 782 777 -5
==========================================
+ Hits 1455 1470 +15
+ Misses 2859 2832 -27
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
rgrunber
commented
Mar 30, 2023
msivasubramaniaan
requested changes
Mar 30, 2023
msivasubramaniaan
requested changes
Mar 31, 2023
Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Todo :
workflow_dispatch(easier to test) to a schedule (daily?)How to test this :
You can create a fork of vscode-openshift-tools, and push this PR onto the
mainbranch (so that GH Actions reads the workflow file from there)Apply something similar to the following patch (can be a separate commit on top of this PR) :
diff
Since the latest odo is currently adopted, this just simulated the case of a newer version. See rgrunber#14 for a sample
Required repo permissions :
Without full read/write permissions, the following error is displayed attempting to push the commit to a branch :
Without pull request approval for GH Actions, the following error is shown :