Skip to content

Switch to first available namespace#2837

Merged
rgrunber merged 1 commit intoredhat-developer:mainfrom
datho7561:2180-nonexistant-namespace
Apr 25, 2023
Merged

Switch to first available namespace#2837
rgrunber merged 1 commit intoredhat-developer:mainfrom
datho7561:2180-nonexistant-namespace

Conversation

@datho7561
Copy link
Copy Markdown
Contributor

When the currently configured namespace doesn't exist, switch to the first available namespace.

Closes #2180

Signed-off-by: David Thompson davthomp@redhat.com

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 17, 2023

Codecov Report

Patch coverage: 40.00% and project coverage change: +0.02 🎉

Comparison is base (8824f77) 33.98% compared to head (f0354f2) 34.00%.

❗ Current head f0354f2 differs from pull request most recent head 5618f79. Consider uploading reports for the commit 5618f79 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2837      +/-   ##
==========================================
+ Coverage   33.98%   34.00%   +0.02%     
==========================================
  Files          70       70              
  Lines        4326     4332       +6     
  Branches      777      778       +1     
==========================================
+ Hits         1470     1473       +3     
- Misses       2856     2859       +3     
Impacted Files Coverage Δ
src/odo/command.ts 13.93% <0.00%> (-0.18%) ⬇️
src/odo3.ts 42.85% <33.33%> (-3.30%) ⬇️
src/explorer.ts 31.48% <50.00%> (-0.60%) ⬇️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@datho7561 datho7561 force-pushed the 2180-nonexistant-namespace branch from f2435ef to de6225e Compare April 17, 2023 21:02
When the currently configured namespace doesn't exist, switch to the
first available namespace.

Closes redhat-developer#2180

Signed-off-by: David Thompson <davthomp@redhat.com>
@datho7561 datho7561 force-pushed the 2180-nonexistant-namespace branch from de6225e to 5618f79 Compare April 18, 2023 15:55
@datho7561 datho7561 marked this pull request as ready for review April 18, 2023 15:57
@datho7561
Copy link
Copy Markdown
Contributor Author

I honestly have no idea if these integration tests (npm urn test-integration) are run anywhere. Most of the suite seems to be failing locally when I use an OpenShift Local (crc) instance.

@datho7561
Copy link
Copy Markdown
Contributor Author

@msivasubramaniaan @rgrunber this PR is ready for review

Comment thread src/explorer.ts
@rgrunber rgrunber merged commit 571fbc8 into redhat-developer:main Apr 25, 2023
@datho7561 datho7561 deleted the 2180-nonexistant-namespace branch April 25, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Namespace non existent should be handled

2 participants