adjusted with marginTop#2935
Merged
msivasubramaniaan merged 2 commits intoredhat-developer:mainfrom Jun 5, 2023
msivasubramaniaan:2931-helm-chart-installation-modal-the-icon-name-and-install-button-should-line-up
Conversation
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #2935 +/- ##
=======================================
Coverage 37.32% 37.32%
=======================================
Files 54 54
Lines 3652 3652
Branches 716 716
=======================================
Hits 1363 1363
Misses 2289 2289 ☔ View full report in Codecov by Sentry. |
Contributor
|
It's not in the centre of the box:
|
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Collaborator
Author
|
|
datho7561
approved these changes
Jun 5, 2023
Contributor
datho7561
left a comment
datho7561
left a comment
There was a problem hiding this comment.
Looks good, but we should go back and clean up this code. We can avoid hardcoding margins by using modern css features like flexbox
| className={this.props.cardItemStyle.cardImage} | ||
| style={{ margin: '0rem' }} /> | ||
| <div style={{ margin: '0rem' }}> | ||
| <div style={{ marginTop: '0.6rem' }}> |
Contributor
There was a problem hiding this comment.
There are better ways to accomplish this than hardcoding the margin, such as flexbox. However, I think this is okay for the release.
msivasubramaniaan
deleted the
2931-helm-chart-installation-modal-the-icon-name-and-install-button-should-line-up
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: msivasubramaniaan msivasub@redhat.com
Fix: #2931
Post Fix:
