Skip to content

adjusted with marginTop #2935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
msivasubramaniaan merged 2 commits into from
Jun 5, 2023
Merged

adjusted with marginTop #2935

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14bae3b
adjusted with marginTop
msivasubramaniaan Jun 5, 2023
216eb05
positioned header middle of the box
msivasubramaniaan Jun 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/webview/common/cardItem.style.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,6 @@ export default (_theme: Theme) =>
flexDirection: 'column'
},
helmCardHeader: {
paddingTop: '1.5rem!important',
borderBottom: '1px solid',
borderBottomColor: 'inherit',
height: 'auto',
Expand Down
4 changes: 2 additions & 2 deletions src/webview/helm-chart/app/cardItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,7 @@ export class CardItem extends React.Component<DevFileProps, {
alt={this.state.selectedVersion.icon + ' logo'}
className={this.props.cardItemStyle.cardImage}
style={{ margin: '0rem' }} />
<div style={{ margin: '0rem' }}>
<div style={{ marginTop: '0.6rem' }}>
Copy link
Copy Markdown
Contributor

@datho7561 datho7561 Jun 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are better ways to accomplish this than hardcoding the margin, such as flexbox. However, I think this is okay for the release.

<Typography variant='subtitle1'>
{
capitalizeFirstLetter(this.props.helmEntry.displayName)
Expand All @@ -326,7 +326,7 @@ export class CardItem extends React.Component<DevFileProps, {
installResponse.loadScreen && <LoadScreen title='Installation in Progress' type='circle' />
}
</div>
<div style={{float: 'right'}}>
<div style={{float: 'right', marginTop: '0.5rem'}}>
<Button
disabled={this.handleDisable() || installResponse.installed}
variant='outlined'
Expand Down
⚡