Show all the devfiles when no devfile.yaml in the git repo#2943
Merged
mohitsuman merged 4 commits intoredhat-developer:mainfrom Jun 6, 2023
Conversation
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
…ith-incorrect-message
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #2943 +/- ##
==========================================
+ Coverage 37.32% 37.34% +0.02%
==========================================
Files 54 54
Lines 3652 3655 +3
Branches 716 717 +1
==========================================
+ Hits 1363 1365 +2
- Misses 2289 2290 +1
☔ View full report in Codecov by Sentry. |
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
datho7561
requested changes
Jun 6, 2023
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
datho7561
approved these changes
Jun 6, 2023
Contributor
datho7561
left a comment
datho7561
left a comment
There was a problem hiding this comment.
Looks good! Thanks, Muthu!
Contributor
|
|
Contributor
|
@msivasubramaniaan feel free to merge if you think it's good to go |
msivasubramaniaan
deleted the
2939-cloning-a-repo-without-any-code-fails-with-incorrect-message
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: msivasubramaniaan msivasub@redhat.com
Fix: #2939
When no
devfile.yaml/languagespecific code were detects, then the git import showed all the list ofdevfilesfrom the registry. User can pick any one. Please refer below:Handling the devfile with dropdown will be part of the #2697