Throw error when login credentials are incorrect#2990
Merged
mohitsuman merged 1 commit intoredhat-developer:mainfrom Jun 28, 2023
Merged
Throw error when login credentials are incorrect#2990mohitsuman merged 1 commit intoredhat-developer:mainfrom
mohitsuman merged 1 commit intoredhat-developer:mainfrom
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2990 +/- ##
==========================================
+ Coverage 37.59% 37.62% +0.03%
==========================================
Files 62 62
Lines 3937 3939 +2
Branches 755 756 +1
==========================================
+ Hits 1480 1482 +2
Misses 2457 2457
☔ View full report in Codecov by Sentry. |
datho7561
requested changes
Jun 27, 2023
Signed-off-by: Jessica He <jhe@redhat.com>
JessicaJHee
force-pushed
the
2979-login-no-error
branch
from
7b94e42 to
fb1364b
Compare
datho7561
approved these changes
Jun 27, 2023
Contributor
datho7561
left a comment
datho7561
left a comment
There was a problem hiding this comment.
Looks good. Thanks, Jessica!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2979