Skip to content

Throw error when login credentials are incorrect #2990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mohitsuman merged 1 commit into from
Jun 28, 2023
+5 −2
Merged

Throw error when login credentials are incorrect #2990

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/openshift/cluster.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,7 +430,7 @@ export class Cluster extends OpenShiftItem {
try {
const result = await Progress.execFunctionWithProgress(
`Login to the cluster: ${clusterURL}`,
() => Cluster.cli.executeTool(Command.odoLoginWithUsernamePassword(clusterURL, username, passwd)));
() => Cluster.cli.executeTool(Command.odoLoginWithUsernamePassword(clusterURL, username, passwd), undefined, true));
Comment thread
datho7561 marked this conversation as resolved.
await Cluster.save(username, passwd, password, result);
return await Cluster.loginMessage(clusterURL, result);
} catch (error) {
Expand Down
5 changes: 4 additions & 1 deletion src/util/filters.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,10 @@ export class Filters {

static readonly passwordRegex = /-p\s+'([^']+)'/;

static readonly passwordAssignRegex = /-p='([^']+)'/;

static filterPassword(value: string): string {
return value ? value.replace(Filters.passwordRegex, '-p **********') : value;
if (!value) return value;
return value.match(Filters.passwordRegex) != null ? value.replace(Filters.passwordRegex, '-p **********') : value.replace(Filters.passwordAssignRegex, '-p=\'**********\'');
}
}
⚡