Skip to content

trim the git URL till repo name#2991

Merged
msivasubramaniaan merged 5 commits intoredhat-developer:mainfrom
msivasubramaniaan:2915-make-sure-that-github-urls-only-contain-first-org-and-repo-name-in-git-import
Jun 28, 2023
Merged

trim the git URL till repo name#2991
msivasubramaniaan merged 5 commits intoredhat-developer:mainfrom
msivasubramaniaan:2915-make-sure-that-github-urls-only-contain-first-org-and-repo-name-in-git-import

Conversation

@msivasubramaniaan
Copy link
Copy Markdown
Collaborator

Fixes: #2915

Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 27, 2023

Codecov Report

Patch coverage: 3.51% and project coverage change: -1.60 ⚠️

Comparison is base (48ed462) 37.59% compared to head (75dca7f) 36.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2991      +/-   ##
==========================================
- Coverage   37.59%   36.00%   -1.60%     
==========================================
  Files          62       63       +1     
  Lines        3937     4125     +188     
  Branches      755      825      +70     
==========================================
+ Hits         1480     1485       +5     
- Misses       2457     2640     +183     
Impacted Files Coverage Δ
src/webview/git-import/gitParse.ts 2.65% <2.65%> (ø)
src/webview/git-import/gitImportLoader.ts 16.46% <18.18%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Comment thread src/webview/git-import/app/gitImport.tsx Outdated
Comment thread src/webview/git-import/gitImportLoader.ts
Comment thread src/webview/git-import/gitImportLoader.ts
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Comment thread src/webview/git-import/app/gitImport.tsx Outdated
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Comment thread src/webview/git-import/gitImportLoader.ts
Copy link
Copy Markdown
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One small comment, feel free to address it and merge or ignore it and merge. Thanks, Muthu!

Comment thread src/webview/git-import/app/gitImport.tsx
@msivasubramaniaan msivasubramaniaan merged commit 5527e7a into redhat-developer:main Jun 28, 2023
@msivasubramaniaan msivasubramaniaan deleted the 2915-make-sure-that-github-urls-only-contain-first-org-and-repo-name-in-git-import branch June 28, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make sure that GitHub URLs only contain first org and repo name in "Git Import"

3 participants