Why is the dependency on vscode-kubernetes added during release? #3091

[vrubezhny]

Fixes: #3091

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: +0.26% 🎉

Comparison is base (943a3c7) 37.03% compared to head (08b3407) 37.30%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3170      +/-   ##
==========================================
+ Coverage   37.03%   37.30%   +0.26%     
==========================================
  Files          75       75              
  Lines        5265     5265              
  Branches     1000     1000              
==========================================
+ Hits         1950     1964      +14     
+ Misses       3315     3301      -14     

see 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[datho7561]

Looks good so far, integration tests are passing for me. You will need to remove the part in the Jenkinsfile that adds the Kubernetes extension to the package.json

[vrubezhny]

Looks good so far, integration tests are passing for me.

Yes, but have you tried running tests from vscode run "Extension Debug Tests" on Debug view?

You will need to remove the part in the Jenkinsfile that adds the Kubernetes extension to the package.json

Sure I'll remove this part

[datho7561]

The tests suites seem debuggable to me, but I needed to add the following:

diff --git a/.vscode/launch.json b/.vscode/launch.json
index 7f70119d..227fe9be 100644
--- a/.vscode/launch.json
+++ b/.vscode/launch.json
@@ -74,7 +74,8 @@
             "sourceMaps": true,
             "preLaunchTask": "instrument",
             "env": {
-                "VSCODE_REDHAT_TELEMETRY_DEBUG":"true"
+                "VSCODE_REDHAT_TELEMETRY_DEBUG": "true",
+                "IS_OPENSHIFT": "true",
             }
         },
         {

for the integration test suite, since I'm using an OpenShift cluster

[vrubezhny]

The tests suites seem debuggable to me, but I needed to add the following:

diff --git a/.vscode/launch.json b/.vscode/launch.json
...

for the integration test suite, since I'm using an OpenShift cluster

Added "IS_OPENSHIFT": "true" to launch.json

[datho7561]

Looks good. Thanks, Victor!