Check for and remove cycles in module dependencies#3189
Merged
datho7561 merged 1 commit intoredhat-developer:mainfrom Sep 7, 2023
Merged
Check for and remove cycles in module dependencies#3189datho7561 merged 1 commit intoredhat-developer:mainfrom
datho7561 merged 1 commit intoredhat-developer:mainfrom
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3189 +/- ##
==========================================
+ Coverage 37.30% 37.56% +0.26%
==========================================
Files 75 77 +2
Lines 5265 5271 +6
Branches 1000 1000
==========================================
+ Hits 1964 1980 +16
+ Misses 3301 3291 -10
☔ View full report in Codecov by Sentry. |
datho7561
force-pushed
the
fix-circular-dependencies
branch
2 times, most recently
from
0a901bc to
a1efb56
Compare
datho7561
changed the title
vrubezhny
previously approved these changes
Sep 7, 2023
Contributor
vrubezhny
left a comment
vrubezhny
left a comment
There was a problem hiding this comment.
Looks good to me and running check cycles returns success:
$ npm run check-cycles
> vscode-openshift-connector@1.7.0 check-cycles
> dpdm --no-tree --no-warning --exit-code circular:1 ./src/extension.ts
✔ [75/75] Analyze done!
• Circular Dependencies
✅ Congratulations, no circular dependency was found in your project.
datho7561
dismissed stale reviews from msivasubramaniaan and vrubezhny
via
5d2e102
datho7561
force-pushed
the
fix-circular-dependencies
branch
from
a1efb56 to
5d2e102
Compare
Having cycles in the modules occaisionally prevents the extension from starting. - Run GitHub Actions check for cycles in module dependencies using dpdm - Fix cli -> tools cycle - Remove cluster -> clusterViewLoader cycle - Move name validation functions out of OpenShiftItem to avoid cycles - Refactor ServerlessFunction -> ServerlessFunctionModel to avoid cycles - Remove view -> loader -> functions cycle Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561
force-pushed
the
fix-circular-dependencies
branch
from
5d2e102 to
ee73678
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having cycles in the modules occasionally prevents the extension from starting.
Signed-off-by: David Thompson davthomp@redhat.com