Skip to content

A new serverless function doesn't appear in os view if created not in ws folder#3255

Merged
msivasubramaniaan merged 3 commits intoredhat-developer:mainfrom
msivasubramaniaan:3136-a-new-serverless-function-doesnt-appear-in-os-view-if-created-not-in-ws-folder
Sep 13, 2023
Merged

A new serverless function doesn't appear in os view if created not in ws folder#3255
msivasubramaniaan merged 3 commits intoredhat-developer:mainfrom
msivasubramaniaan:3136-a-new-serverless-function-doesnt-appear-in-os-view-if-created-not-in-ws-folder

Conversation

@msivasubramaniaan
Copy link
Copy Markdown
Collaborator

Fixes: #3136

Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 12, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.03% ⚠️

Comparison is base (33a5974) 37.29% compared to head (7607133) 37.26%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3255      +/-   ##
==========================================
- Coverage   37.29%   37.26%   -0.03%     
==========================================
  Files          77       77              
  Lines        5248     5252       +4     
  Branches      993      993              
==========================================
  Hits         1957     1957              
- Misses       3291     3295       +4     
Files Changed Coverage Δ
src/serverlessFunction/functionModel.ts 31.94% <0.00%> (-1.88%) ⬇️
...ew/serverless-function/serverlessFunctionLoader.ts 14.01% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mohitsuman mohitsuman changed the title 3136 a new serverless function doesn't appear in os view if created not in ws folder A new serverless function doesn't appear in os view if created not in ws folder Sep 12, 2023
@msivasubramaniaan
Copy link
Copy Markdown
Collaborator Author

@vrubezhny Can you please review?

Copy link
Copy Markdown
Contributor

@vrubezhny vrubezhny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@msivasubramaniaan msivasubramaniaan merged commit b61fd80 into redhat-developer:main Sep 13, 2023
@msivasubramaniaan msivasubramaniaan deleted the 3136-a-new-serverless-function-doesnt-appear-in-os-view-if-created-not-in-ws-folder branch September 13, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A new serverless function doesn't appear in OS View if created not in WS folder

2 participants